[OPEN-ILS-DEV] PATCH: osrf_chat_main.c (error handling)

Scott McKellar mck9 at swbell.net
Sun Jun 10 17:42:28 EDT 2007


This patch polishes the error handling a bit in ChopChop.

1. If osrfConfigInit() fails I issue a message and return immediately, 
without trying to extract anything from a non-existent configuration.

2. If one or more of the required configuration parameters is missing, 
I issue a separate message for each one, so that the user knows what
to fix.

3. I removed the existing message about a missing log file.  If the
log file were missing, the program would exit before it got to that
point, so the message could never be issued in practice.

4. I fixed an evident typo in a call to osrfLogInit().

Scott McKellar
http://home.swbell.net/mck9/aargh/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_chat_main_c_1.patch
Type: text/x-patch
Size: 2005 bytes
Desc: 3653375360-osrf_chat_main_c_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070610/2b5d7eed/osrf_chat_main_c_1.bin


More information about the Open-ils-dev mailing list