[OPEN-ILS-DEV] PATCH: osrf_settings.c

[Mike Rylander]

On 6/2/07, Scott McKellar <mck9 at swbell.net> wrote:
> This patch chips away at the "config pointer is NULL" problem that
> some people still report from time to time.

Applied with adjusted log messages.

[snip]

> ----------
>
> One other observation:
>
> The config pointer in question is defined at global scope in
> osrf_settings.c.  However it is not declared in the corresponding
> header file.  I strongly suspect that it is intended to be
> accessed only from within the source file where it resides.
>
> In that case it should be declared static.
>
> However it is conceivable that some other header declares this
> pointer, or that some other module declares it outside of a header.
> I doubt it, but it's possible.
>
> Unfortunately if I grep for "config" I'll get a ton of spurious
> hits, and I'm too lazy to go through them to verify that they all
> refer to something else.
>
> As a result, this patch doesn't change the declaration of the config
> pointer.  Mike or Bill can decide much more readily than I can
> whether the config pointer deserves to be static.

Bill, eh?  I think it's probably a good candidate for making static,
since there will surely end up being name collisions at some point
otherwise.

Thanks, Scott.

--miker

>
> Scott McKellar
> http://home.swbell.net/mck9/aargh/
>
> ------------------------
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.
>


-- 
Mike Rylander