[OPEN-ILS-DEV] PATCH: osrf_system.c (avoiding "config file is NULL")

Mike Rylander mrylander at gmail.com
Mon Jun 11 21:16:38 EDT 2007


On 6/3/07, Scott McKellar <mck9 at swbell.net> wrote:
> This is another patch addressing the "config pointer is NULL" issue.

Applied, along with ...

[snip]

> --------------
>
> So far as I can tell, the only application affected by this patch
> will be opensrf.  It calls osrfSystemBootstrap() but does not check
> the return code -- possibly because, until recently, a successful
> call would enter an endless loop that could be interrupted only by
> killing the process.
>
> Now the loop ends when all child processes have terminated, or when
> wait() encounters an error.  osrfSystemBootstrap() returns zero in
> either case.  It returns non-zero only if it never gets to the point
> of spawning child processes in the first place.
>
> I wonder if opensrf should now check the return code, and issue a
> message if it's non-zero.

... just such an error message.  It won't do much but give us a
specific target in the logs, but sometimes that's enough.

Thanks, Scott.

--miker


More information about the Open-ils-dev mailing list