[OPEN-ILS-DEV] PATCH: log.[ch] (localizing various things)

[Bill Erickson]

On 6/18/07, Mike Rylander <mrylander at gmail.com> wrote:
>
> I've attached a slight reworking of your patch for general
> consumption.  Comments below.
>
> Thanks, Scott
>
> --miker
>
> On 6/17/07, Scott McKellar <mck9 at swbell.net> wrote:
> > This patch tidies up log.h and log.c a bit, mostly by moving various
> > things from the former to the latter.  In all cases I verified that
> > no other source code referenced the things changed, apart from a
> > few spurious matches in some python modules.
> >
> > 1. Whenever a declared identifier had two leading underscores, I
> > removed the first one, except for a few cases where I removed the
> > second one and kept the first one.
> >
> > 2. I moved the following macros to log.c:
> >
> >  OSRF_LOG_ERROR
> >  OSRF_LOG_WARNING
> >  OSRF_LOG_INFO
> >  OSRF_LOG_DEBUG
> >  OSRF_LOG_INTERNAL
> >  OSRF_LOG_ACTIVITY
> >  OSRF_LOG_GO
>
> For the time being I'm going to leave these defined in the header,
> along with the osrfLogSetLevel() function, as I can certainly see the
> need, during development of an application, to change the logging
> level for a short section of code.  To support that, I'm going to add
> a osrfLogGetLevel() function to retrieve the current level for later
> resetting.


I think that makes the most sense for now.  As Scott pointed out, no one's
currently using the log levels directly, but I can imagine cases where it
might be handy.

[snip]

Thanks Scott and Mike :)

-bill


-- 
Bill Erickson
PINES Systems Developer
Georgia Public Library Service
billserickson at gmail.com
http://open-ils.org
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070618/44801cca/attachment-0001.html