[OPEN-ILS-DEV] PATCH: osrf_system.c

[Scott McKellar]

This patch includes a collection of tweaks to the
osrf_system_bootstrap_client_resc function.  These tweaks are pretty
much independent of each other, so you can pick and choose which ones
you want to keep.

1. In an earlier proposed patch I fixed a segfault that occurred 
when the config file was empty or didn't specify a domain.  In that 
patch I simply replaced the domain with an empty string.

The current patch provides an alternative approach.  I issue a
message to stderr, release locally allocated resources, and return 0
to indicate failure.

2. If the configuration file doesn't specify a log file, we issue an
error message and return -1.  I added some code to plug some memory
leaks.  I also expanded the error message to make it more informative.
If I were a naive user and got a message that just said "Log file 
needed", I would have trouble figuring out exactly what that meant.

3. I made the host variable const.  Whoop ti do.

4. I eliminated a couple of pointless calls to memset().

Scott McKellar
http://home.swbell.net/mck9/aargh/

Developer’s Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_system_c_2.patch
Type: text/x-patch
Size: 3272 bytes
Desc: 155480816-osrf_system_c_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070519/cd1c4bf8/osrf_system_c_2.bin