[OPEN-ILS-DEV] PATCH: osrf_system.c

Scott McKellar mck9 at swbell.net
Mon May 21 09:12:24 EDT 2007


--- Mike Rylander <mrylander at gmail.com> wrote:

<snip>
 
> I'm not certain I follow.  Do you mean extra text nodes in the DOM
> tree that show up as strings of whitespace between, say, the <config>
> element and the <srfsh> element?  If so, I can't think of any reason
> that those should be considered meaningful, and should be ignored.

No, I'm referring to non-whitespace text, such as:

<srfsh>
        <router_name>router</router_name>
        <domains>
                <domain>localhost</domain>
        </domains>
        <username>osrf</username> Extra text here
        <passwd>osrf</passwd>
        <port>5222</port>
        <logfile>/openils/var/log/srfsh.log</logfile>
        <loglevel>4</loglevel>
</srfsh>

We appear to skip over the text between tags if it's all white space,
but if there's anything other than whitespace, we capture all of 
the text -- including the whitespace.

It might not break if the extra text comes last -- e.g. after
the loglevel element in the above example.  I haven't tried that
yet.

Give it a try -- add some extraneous text and see what happens when
you run, for example, srfsh.  Things might work a little differently
in your environment, especially if you're using a different version
of object.c with more sanity checking.  

It's a bit convoluted.  I'm at work now and can't go into the details.
I'll explain further tonight when I get home, if you don't find it
yourself first.

Scott McKellar
http://home.swbell.net/mck9/aargh/



More information about the Open-ils-dev mailing list