[OPEN-ILS-DEV] PATCH: transport_session.c

[Scott McKellar]

In session_connect(), if we don't already have a non-zero sock_id, 
we try to get one, using either a port number or a UNIX path.  If 
we have neither port nor path, the sock_id remains zero.

Since zero normally designates standard input, trying to open socket
zero is not likely to be productive, unless you're doing something
really funky with standard input.

In this patch, if we have neither port nor path, I log a message
and return immediately, so that the problem will be easier to 
diagnose.  Currently the log complains about trying to apply socket
operations to a non-socket file descriptor, but it would take some
extra head-scratching to figure out what was really going on.

Scott McKellar
http://home.swbell.net/mck9/aargh/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: transport_session_c_1.patch
Type: text/x-patch
Size: 470 bytes
Desc: 3591682290-transport_session_c_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070528/731f9e77/transport_session_c_1.bin