[OPEN-ILS-DEV] PATCH: oils_requestor.c (const-correctness)

[Scott McKellar]

This patch sprinkles the const qualifier over oils_requestor.c.  In
addition:

1. It replaces the deprecated osrf_app_session_make_req function with
the equivalent osrfAppSessionMakeRequest function.

2. It plugs a memory leak where format_request() was calling itself
recursively without freeing the result.

3. In a couple of places it replaces buffer_data() with 
buffer_release() in order to eliminate a round of malloc() and free().

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oils_requestor_c_3.patch
Type: text/x-patch
Size: 2965 bytes
Desc: 2992154576-oils_requestor_c_3.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20071118/8271d1d1/oils_requestor_c_3.bin