[OPEN-ILS-DEV] PATCH: osrf_message.[ch] (const correctness)

Scott McKellar mck9 at swbell.net
Thu Oct 25 22:48:15 EDT 2007


These patches add the const qualifier to a number of parameters in
the messaging functions.

In order to make the constness possible I rearranged the code a bit
in osrf_message_set_params().  It had reused one of the pointer
parameters as an intermediate (non-const) variable.  I eliminated
the reuse so that I could make the pointer parameter const.

In osrf_message_set_default_locale() I eliminated a memcpy() (and a
manual addition of a terminal nul) with an equivalent call to 
strcpy(), thereby eliminating two calls to strlen().  I also replaced
a hard-coded buffer length with the sizeof operator.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_message_h_1.patch
Type: text/x-patch
Size: 3104 bytes
Desc: 1508309634-osrf_message_h_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20071025/a22f5024/osrf_message_h_1.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_message_c_2.patch
Type: text/x-patch
Size: 5617 bytes
Desc: 609612645-osrf_message_c_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20071025/a22f5024/osrf_message_c_2.bin


More information about the Open-ils-dev mailing list