[OPEN-ILS-DEV] PATCH: osrf_json_tools.c (const-correctness)
Scott McKellar
mck9 at swbell.net
Sat Sep 22 23:04:42 EDT 2007
These patches fine-tune some const-correctness in osrf_json_tools.c.
1. I changed the signature of jsonObjectDecodeClass so that it accepts
a non-const pointer parameter. Since it doesn't change the contents
of the jsonObject, there's no need to confine it to non-const
jsonObjects.
2. I replaced jsonObjectGetKey() with jsonObjectGetKeyConst().
3. In one spot I captured the return value of jsonObjectGetIndex()
with a const pointer instead of a non-const pointer.
The second item above relies on the prior application of a previous
pair of patches that I submitted earlier today.
Scott McKellar
http://home.swbell.net/mck9/ct/
Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or
(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and
(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_json_h_3.patch
Type: text/x-patch
Size: 568 bytes
Desc: 2693401005-osrf_json_h_3.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070922/6d9562bf/osrf_json_h_3.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_json_tools_c_2.patch
Type: text/x-patch
Size: 2041 bytes
Desc: 4162992874-osrf_json_tools_c_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20070922/6d9562bf/osrf_json_tools_c_2.bin
More information about the Open-ils-dev
mailing list