[OPEN-ILS-DEV] PATCH: osrf_transgroup.c (initializing buffers)

Mike Rylander mrylander at gmail.com
Fri Apr 11 08:52:47 EDT 2008


On Tue, Mar 11, 2008 at 11:01 PM, Scott McKellar <mck9 at swbell.net> wrote:
> This patch elinminates the use of the osrf_clearbuf macro in several
>  spots.  In each case, the buffer needs to be initialized to an empty
>  string, because the call to jid_get_* doesn't necessarily populate it
>  with anything else.  In debugging mode, osrf_clearbuf() will fill the
>  field with exclamation points, which is not helpful in this context.

Applied ... finally.

>
>  Probably the jid_get_* routines should render the output string
>  empty if they can't find what they're looking for.  However that's a
>  patch for another day.
>
>  Scott McKellar
>  http://home.swbell.net/mck9/ct/
>
>  Developer's Certificate of Origin 1.1 By making a contribution to
>  this project, I certify that:
>
>  (a) The contribution was created in whole or in part by me and I
>  have the right to submit it under the open source license indicated
>  in the file; or
>
>  (b) The contribution is based upon previous work that, to the best
>  of my knowledge, is covered under an appropriate open source license
>  and I have the right under that license to submit that work with
>  modifications, whether created in whole or in part by me, under the
>  same open source license (unless I am permitted to submit under a
>  different license), as indicated in the file; or
>
>  (c) The contribution was provided directly to me by some other person
>  who certified (a), (b) or (c) and I have not modified it; and
>
>  (d) In the case of each of (a), (b), or (c), I understand and agree
>  that this project and the contribution are public and that a record
>  of the contribution (including all personal information I submit
>  with it, including my sign-off) is maintained indefinitely and may
>  be redistributed consistent with this project or the open source
>  license indicated in the file.



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone: 1-877-OPEN-ILS (673-6457)
 | email: miker at esilibrary.com
 | web: http://www.esilibrary.com


More information about the Open-ils-dev mailing list