[OPEN-ILS-DEV] PATCH: osrf_hash.[ch] (new function)

[Mike Rylander]

On Tue, Mar 25, 2008 at 10:54 PM, Scott McKellar <mck9 at swbell.net> wrote:
> This patch adds a new function so that code outside of osrf_hash.c
>  doesn't have to directly access the "current" member of an
>  osrfHashIterator.  This bit of encapsulation will make it easier
>  to refactor the osrfHash code.
>
>  Note that I submitted some patches to the same files a few days ago
>  to the same files, having to do with reusing the memory used for the
>  "current" member.  Those earlier patches are still okay, but they
>  will be superceded by a more extensive rewrite in the near future,
>  so it may not be worthwhile to bother with them in the meanwhile.
>
>  The changes in the present patch files are independent of those
>  patches.  I manually edited these patches to strip out the earlier
>  changes.  I think they will still work, but if they don't because
>  I mangled something, you can either apply the same changes manually
>  or ask me for a better patch.  I have just made a little extra
>  trouble for myself by sending too many patches to the same files
>  too quickly.

Applied.  The patch to osrf_hash.c wasn't happy, but it was a simple
addition so I added it by hand.

OT: I've been swamped recently with UI code (blarg!) but I will try to
be better about getting your patches in faster to keep your trouble to
a minimum.

Thanks, as always!

>
>  Scott McKellar
>  http://home.swbell.net/mck9/ct/
>
>  Developer's Certificate of Origin 1.1 By making a contribution to
>  this project, I certify that:
>
>  (a) The contribution was created in whole or in part by me and I
>  have the right to submit it under the open source license indicated
>  in the file; or
>
>  (b) The contribution is based upon previous work that, to the best
>  of my knowledge, is covered under an appropriate open source license
>  and I have the right under that license to submit that work with
>  modifications, whether created in whole or in part by me, under the
>  same open source license (unless I am permitted to submit under a
>  different license), as indicated in the file; or
>
>  (c) The contribution was provided directly to me by some other person
>  who certified (a), (b) or (c) and I have not modified it; and
>
>  (d) In the case of each of (a), (b), or (c), I understand and agree
>  that this project and the contribution are public and that a record
>  of the contribution (including all personal information I submit
>  with it, including my sign-off) is maintained indefinitely and may
>  be redistributed consistent with this project or the open source
>  license indicated in the file.
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone: 1-877-OPEN-ILS (673-6457)
 | email: miker at esilibrary.com
 | web: http://www.esilibrary.com