[OPEN-ILS-DEV] buffer_chomp()

Scott McKellar mck9 at swbell.net
Tue Dec 2 10:40:47 EST 2008


--- On Tue, 12/2/08, Dan Scott <dan at coffeecode.net> wrote:

> From: Dan Scott <dan at coffeecode.net>
> Subject: Re: [OPEN-ILS-DEV] buffer_chomp()
> To: mck9 at swbell.net, "Evergreen Development Discussion List" <open-ils-dev at list.georgialibraries.org>
> Date: Tuesday, December 2, 2008, 8:27 AM
> Hi Scott:
> 
> 2008/12/1 Scott McKellar <mck9 at swbell.net>:
> > The other day I noticed the new buffer_chomp function.
>  It removes the
> > last character of a growing_buffer, and returns the
> new length.
> 
> <snip>
> 
> > I can incorporate these two changes into my next patch
> to utils.[ch] --
> > which will probably be soon, because I want to get rid
> of the new
> > buffer_append_uescape function in favor of the newer
> function
> > buffer_append_utf8().
> 
> Oh, uh - I think I already checked in that change,
> including the
> required change to osrf_json_object.c and the Makefile, as
> part of
> changeset 1516
> (http://svn.open-ils.org/trac/OpenSRF/changeset/1516).

Okay, you beat me to it.  I'll go ahead with the other changes.  I'll
also drop the buffer_append_uescape function from utils.c, since
you've already dropped the prototype from the header, and we have no
further use for it.

Scott McKellar
http://home.swbell.net/mck9/ct/



More information about the Open-ils-dev mailing list