[OPEN-ILS-DEV] PATCH: json_xml.c (miscellaneous)

Scott McKellar mck9 at swbell.net
Sat Feb 23 23:12:26 EST 2008


This patch is a minor cleanup.

1. The functions _rest_xml_output and _escape_xml are now static, and
a couple of their parameters are now const.

2. In json_string_to_xml() we were leaking res_xml in the case of an
early return.  I moved the early return out of the way.

3. In _rest_xml_output() we were leaking tag in the case of an early
return.  I plugged that leak.

4. In a couple of spots I replaced buffer_data() with buffer_release(),
and eliminated two intermediate variables that are no longer needed.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: json_xml_c_1.patch
Type: text/x-patch
Size: 2576 bytes
Desc: 1140426227-json_xml_c_1.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080223/5909287e/json_xml_c_1.bin


More information about the Open-ils-dev mailing list