[OPEN-ILS-DEV] PATCH: osrf_prefork.[ch] (miscellaneous)

[Mike Rylander]

On Jan 6, 2008 6:04 PM, Scott McKellar <mck9 at swbell.net> wrote:
> These patches are a code cleanup, and should not affect functionality.

And, finally, applied.  Scott, you are a machine. :)

>
> 1. I moved almost everything from the header file into the
> implementation file, since it isn't referenced elsewhere.  All that's
> left is one function prototype and a series of nested #includes.
>
> 2. I added compilation guards to the header.
>
> 3. Except for osrf_prefork_run(), all functions are now static, as is
> the child_dead variable.
>
> 4. I commented out the MAX_BUFSIZE macro, since it isn't used.
>
> 5. I removed the declaration of main(), which seemed rather pointless.
>
> 6. I added the const qualifier to the parameters of osrf_prefork_run()
> and osrf_prefork_routers().
>
> 7. I made sure that all members were explicitly initialized when
> creating a prefork_simple or a prefork_child.
>
> 8. I commented out both the prototype and the definition of
> find_prefork_child(), since we don't call it anywhere.
>
> ----------
>
> The header file retains a long list of nested  #includes, of which
> none is necessary for the remaining function prototype.  They should
> all go into the implementation file.  Any other implmentation file
> that needs them (and doesn't already have them) should #include them
> itself as needed.  However that change would involve more untangling
> than I'm up for at the moment.
>
> Scott McKellar
> http://home.swbell.net/mck9/ct/
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com