[OPEN-ILS-DEV] PATCH: osrf_router.[ch] (miscellaneous)

[Scott McKellar]

These patches plug a couple of memory leaks, but otherwise are a code
cleanup that shouldn't affect functionality.

1. In the header: I added compilation guards.

2. In the header: I changed leading double underscores to leading
single underscores.  These identifiers don't appear elsewhere in the
code base, with either double or single underscores.

3. I moved most of the header into the implementation file.  The 
headers whose prototypes I moved are now static.  Where there were
comments associated with the prototypes, I moved them to the function
definitions.

4. I removed an extra leading underscore from __osrfRouterFillFDSet().

5. I replaced some deprecated identifiers with their camel-case
equivalents:

    osrf_message_free   ==> osrfMessageFree
    osrf_message        ==> osrfMessage

6. I added the const qualifier to several function parameters.

7. In a couple of spots we were failing to free classname buffers.
I plugged those leaks.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_router_h_2.patch
Type: text/x-patch
Size: 6648 bytes
Desc: 3622781024-osrf_router_h_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080110/0b19c5a1/osrf_router_h_2.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_router_c_2.patch
Type: text/x-patch
Size: 17724 bytes
Desc: 3800199421-osrf_router_c_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080110/0b19c5a1/osrf_router_c_2.bin