[OPEN-ILS-DEV] PATCH: osrf_application.[ch] (miscellaneous)

Scott McKellar mck9 at swbell.net
Sun Jan 13 11:10:22 EST 2008


These patches tidy up a few things an plug a memory leak.

1. I moved the declarations of the following functions out of the
header and into the implementation file, and declared the functions
as static:

    _osrfAppBuildMethod
    _osrfAppFindApplication
    __osrfAppFindMethod (and removed both underscores)
    __osrfAppRunSystemMethod (and removed one underscore)
    __osrfAppRegisterSysMethods (and removed one underscore)
    __osrfAppPostProcess (and removed one underscore)
    _osrfAppRespond
    osrfAppIntrospect
    osrfAppIntrospectAll
    osrfAppEcho
    osrfAppSetOnExit

2. I plugged a memory leak in osrfAppRunExitCode (we weren't freeing
the osrfHashIterator).

3. I made sure to populate all members of a new osrfMethod.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_application_h_2.patch
Type: text/x-patch
Size: 3429 bytes
Desc: 68104701-osrf_application_h_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080113/db0980d7/osrf_application_h_2.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_application_c_2.patch
Type: text/x-patch
Size: 9670 bytes
Desc: 2182214915-osrf_application_c_2.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080113/db0980d7/osrf_application_c_2.bin


More information about the Open-ils-dev mailing list