[OPEN-ILS-DEV] PATCH: osrf_app_session.c (memory leaks)

[Scott McKellar]

This patch plugs a few memory leaks, and replaces a few deprecated
identifiers.

1. I replaced the following identifiers with their camel-case 
equivalents:

    osrf_message             ==> osrfMessage
    osrf_message_free        ==> osrfMessageFree
    string_array             ==> osrfStringArray
    string_array_get_string  ==> osrfStringArrayGetString

2. In osrf_app_server_session_init() we were leaking session in the
case of an early return.  I stuck in a free().

3. Likewise in osrfAppSessionMakeLocaleRequest() we were leaking req
in the case of an early return.  I plugged that one too.

4. In osrfAppRequestRespondComplete() we were leaking payload in one
branch of an if/else.  I moved the osrfMessageFree() beyond both
branches so that it would be unconditional.

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: osrf_app_session_c_6.patch
Type: text/x-patch
Size: 15778 bytes
Desc: 3809673205-osrf_app_session_c_6.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080113/f9783e44/osrf_app_session_c_6.bin