[OPEN-ILS-DEV] PATCH: srfsh.c (memory leak)

Scott McKellar mck9 at swbell.net
Tue Jan 15 01:56:31 EST 2008


1. In send_request() we allocate a jsonObject o and then immediately
assign the resulting pointer to params.  I eliminated the rather
pointless o and allocated params directly.

2. We didn't ever free params.  Now we do.

3. I replaced two deprecated identifiers with their camel-case
equivalents:

    osrf_app_client_session_init   ==> osrfAppSessionClientInit
    osrf_message_free              ==> osrfMessageFree

Scott McKellar
http://home.swbell.net/mck9/ct/

Developer's Certificate of Origin 1.1 By making a contribution to
this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license indicated
in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source license
and I have the right under that license to submit that work with
modifications, whether created in whole or in part by me, under the
same open source license (unless I am permitted to submit under a
different license), as indicated in the file; or

(c) The contribution was provided directly to me by some other person
who certified (a), (b) or (c) and I have not modified it; and

(d) In the case of each of (a), (b), or (c), I understand and agree
that this project and the contribution are public and that a record
of the contribution (including all personal information I submit
with it, including my sign-off) is maintained indefinitely and may
be redistributed consistent with this project or the open source
license indicated in the file.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: srfsh_c_13.patch
Type: text/x-patch
Size: 3112 bytes
Desc: 953822567-srfsh_c_13.patch
Url : http://list.georgialibraries.org/pipermail/open-ils-dev/attachments/20080114/83e77cbf/srfsh_c_13.bin


More information about the Open-ils-dev mailing list