[OPEN-ILS-DEV] PATCH: osrf_json_gateway.c (memory leaks)

[Mike Rylander]

On Jan 15, 2008 9:43 PM, Scott McKellar <mck9 at swbell.net> wrote:
> This patch plugs a few more memory leaks, and replaces some deprecated
> identifiers with their camel-case equivalents.
>

Applied, with one minor change(1).  Commit message changed from your
text to reflect the modification.

> 1. In osrf_json_gateway_child_init(): we were leaking allowedServices.

AFAICT, this is a global used to test if a request is against a valid
service.  I removed the free from the patch.

>
> 2. In osrf_json_gateway_method_handler(): we were leaking the
> jsonObject arr.
>
> 3. Also in osrf_json_gateway_method_handler(): we were leaking session
> in the case of an early exit.
>
> 4. Replaced identifiers:
>
>     osrf_app_client_session_init   ==> osrfAppSessionClientInit
>     osrf_app_session               ==> osrfAppSession (struct)
>     osrf_message                   ==> osrfMessage
>     osrf_message_free              ==> osrfMessageFree
>     string_array                   ==> osrfStringArray
>     string_array_destroy           ==> osrfStringArrayFree
>
> Scott McKellar
> http://home.swbell.net/mck9/ct/
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com