[OPEN-ILS-DEV] PATCH: xml_utils.[ch] (const-correctness)

[Mike Rylander]

On Jan 20, 2008 7:17 PM, Scott McKellar <mck9 at swbell.net> wrote:
> Two little tweaks:

Applied.  I agree with your assessment of _xmlToJSON, both on design
and current impact.

>
> 1. I added the const qualifier to the second parameter of xmlSaxAttr().
>
> 2. I moved the prototype of _xmlToJSON() from the header to the
> implementation file, and made the function static.
>
> At least in its present form, _xmlToJSON should not be part of the
> public interface because it is confusing.  Sometimes it allocates a
> new jsonObject, which needs to be freed, and sometimes it doesn't.
>
> A better design would be for it to expect to receive a non-NULL pointer
> to an existing jsonObject.  Since it is called in only one place
> (other than a couple of recursive calls), this would be an easy
> change to make.  However I left it alone -- as long as the function
> is visible only from within its own source file, the potential for
> confusion is limited.
>
> Scott McKellar
> http://home.swbell.net/mck9/ct/
>
> Developer's Certificate of Origin 1.1 By making a contribution to
> this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
> have the right to submit it under the open source license indicated
> in the file; or
>
> (b) The contribution is based upon previous work that, to the best
> of my knowledge, is covered under an appropriate open source license
> and I have the right under that license to submit that work with
> modifications, whether created in whole or in part by me, under the
> same open source license (unless I am permitted to submit under a
> different license), as indicated in the file; or
>
> (c) The contribution was provided directly to me by some other person
> who certified (a), (b) or (c) and I have not modified it; and
>
> (d) In the case of each of (a), (b), or (c), I understand and agree
> that this project and the contribution are public and that a record
> of the contribution (including all personal information I submit
> with it, including my sign-off) is maintained indefinitely and may
> be redistributed consistent with this project or the open source
> license indicated in the file.



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com