[OPEN-ILS-DEV] PATCH: osrf_prefork.c (latent bugs)

[Mike Rylander]

On Mon, Mar 3, 2008 at 12:15 AM, Scott McKellar <mck9 at swbell.net> wrote:
> 1. Pedantic: I changed child_dead from an int to a sig_atomic_t, since
>  we set it from a signal handler.
>
>  2. In check_children() and prefork_child_wait(), we prepare an input
>  buffer for a read() by calling the osrf_clearbuf macro.  Depending on
>  the existence of NDEBUG, this macro may or may not do the right thing.
>  If it does the wrong thing, it will pad the input data with
>  exclamation points, up to the maximimum length.
>
>  I added code to explicitly add a terminal nul, thus rendering
>  the osrf_clearbuf macro both harmless and superfluous.
>
>  This issue is the same one that I mentioned yesterday in connection
>  with socket_bundle.c, so I shall not belabor it here.
>
>  3. In addition: in check_children() I arranged to issue the debug
>  message only if the read is successful.

Applied.

>
>  Scott McKellar
>  http://home.swbell.net/mck9/ct/
>
>  Developer's Certificate of Origin 1.1 By making a contribution to
>  this project, I certify that:
>
>  (a) The contribution was created in whole or in part by me and I
>  have the right to submit it under the open source license indicated
>  in the file; or
>
>  (b) The contribution is based upon previous work that, to the best
>  of my knowledge, is covered under an appropriate open source license
>  and I have the right under that license to submit that work with
>  modifications, whether created in whole or in part by me, under the
>  same open source license (unless I am permitted to submit under a
>  different license), as indicated in the file; or
>
>  (c) The contribution was provided directly to me by some other person
>  who certified (a), (b) or (c) and I have not modified it; and
>
>  (d) In the case of each of (a), (b), or (c), I understand and agree
>  that this project and the contribution are public and that a record
>  of the contribution (including all personal information I submit
>  with it, including my sign-off) is maintained indefinitely and may
>  be redistributed consistent with this project or the open source
>  license indicated in the file.



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com