[OPEN-ILS-DEV] SPAM: autoconf support for openSRF (resubmission)

[Kevin Beswick]

On Fri, May 16, 2008 at 11:09 AM, Bill Erickson <erickson at esilibrary.com> wrote:
> Some comments:
>
> When I invoke 'automake -a', I get some warnings:
>
> configure.ac: no proper invocation of AM_INIT_AUTOMAKE was found.
> configure.ac: You should verify that configure.ac invokes AM_INIT_AUTOMAKE,
> configure.ac: that aclocal.m4 is present in the top-level directory,
> configure.ac: and that aclocal.m4 was recently regenerated (using aclocal).
> configure.ac: installing `./install-sh'
> configure.ac: installing `./missing'
> automake: no `Makefile.am' found for any configure output
>
> Should I fear these?

Not yet. I am still working on the automake portion, which requires
the Makefile.am file. automake -a is just installing install-sh
(required file) for now.

> ------------------
>
> It's also important to note that if you run ./configure as a non-root user, it
> may die with:
>
> checking for ejabberd... no
> configure: error: *** ejabberd not found, aborting
>
> /usr/sbin, where ejabberd lives on my test system (Debian Lenny), is not in my
> path.
>
> This works fine:
>
> PATH=$PATH:/usr/sbin/ ./configure
>

Thanks for pointing that out, I will fix this.

> ------------
>
> I ran configure with the defaults and later realized that I needed to update
> my tmp_dir, since it was already in use by another user on this system.  I
> ran:
>
> PATH=$PATH:/usr/sbin/ ./configure --with-tmp_dir=/tmp/osrftmp
>
> The configure output reports:
>
> Tmp dir location:         /tmp/osrftmp
>
> However, Makefile[.in] still shows TMP=/tmp/ilstemp, which causes my 'make'
> attempts to fail.
>
> Should re-running configure update that?  It's likely my own autoconf
> ignorance is coming into play here...
>
Nope, totally my fault. I forgot to update the Makefile.in's hardcoded
locations for the install directories (prefix,tmp, whatever) with
variables set by configure

> -----------------
>
> Minor nit:  Can we make the default TMP directory /tmp/osrftmp (or similar)?
>
Yes, no problem!

> ---------------
>
> To prevent filling up the file, can we wrap the mod_placeholder insertion
> (in 'make install') in a check to see if it's needed?  For example:
>
> if [ ! $$(grep mod_placeholder /etc/apache2/httpd.conf) ]; then \
>    echo "#LoadModule
> mod_placeholder /usr/lib/apache2/modules/mod_placeholder.so" \
>        >> /etc/apache2/httpd.conf; \
>    fi; \
> make -s -C src install
>

For sure.

> ----------------------
>
> Kevin, this is looking /very/ good.  I didn't realize you had gotten this far
> until I went for it.  Kudos.
>
> -bill
>
Thanks! I'm stuck on the automake now with a few problems, which are
getting resolved slowly.

Kevin