[OPEN-ILS-DEV] PATCH: osrf_json.c (rewrite of jsonObjectToJSON[Raw])

Scott McKellar mck9 at swbell.net
Tue Nov 18 19:47:29 EST 2008


--- On Tue, 11/18/08, Bill Erickson <erickson at esilibrary.com> wrote:

> OK, I tracked down 2 problems, the first makes sense, the
> second, not so  
> much.
> 
> The first problem was the result of attempting to escape
> quotes (") and  
> backslashes (\) in the final if/else block of
> buffer_append_uescape().   
> Since " and \ are both >= ' ', they
> were not getting escaped.

Doh! <blush/> Sorry.
 
> The second was caused by NULL jsonObject's being passed
> from  
> OSRF_LIST_GET_INDEX (osrf_json_object:337) into
> add_json_to_buffer().   
> osrfList allows NULL entries, so it seems the old could
> should have been  
> dying here, but for some reason only the new code suffers.

This one I don't understand.  Is it working now, somehow?  If it is,
then I won't worry about it.

Scott McKellar
http://home.swbell.net/mck9/ct/



More information about the Open-ils-dev mailing list