[OPEN-ILS-DEV] Permission List i18n-ized

[Dan Scott]

2008/10/29 Craig <slazer at gmail.com>:
> Patch Description:
> This patch i18n-izes the perm_list.html and perm_list.js files in conify.
>
> Files changed are:
> - Open-ILS/web/conify/global/permission/perm_list.html
> - Open-ILS/web/conify/global/permission/perm_list.js
> - Open-ILS/web/opac/locale/en-US/conify.dtd
>
> Files added are:
> - Open-ILS/web/js/dojo/openils/conify/nls/prml.js
>
>
> Developer's Certificate of Origin 1.1
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
>    have the right to submit it under the open source license
>    indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
>    of my knowledge, is covered under an appropriate open source
>    license and I have the right under that license to submit that
>    work with modifications, whether created in whole or in part
>    by me, under the same open source license (unless I am
>    permitted to submit under a different license), as indicated
>    in the file; or
>
> (c) The contribution was provided directly to me by some other
>    person who certified (a), (b) or (c) and I have not modified
>    it.
>
> (d) I understand and agree that this project and the contribution
>    are public and that a record of the contribution (including all
>    personal information I submit with it, including my sign-off) is
>    maintained indefinitely and may be redistributed consistent with
>    this project or the open source license(s) involved.
>
> Signed-off-by: Craig Ricciuto - slazer at gmail.com

Hi Craig:

Thanks for the patch. I made a few modifications, some of which were
necessary, some which were more-or-less cosmetic but in keeping with
the style of the other Conify i18n patches:

  * (style) changed "prml" to "pgt" throughout to use the
permission.grp_tree class hint from fm_IDL.xml
  * (required) added a dojo.requireLocalization() clause to
perm_list.js to register the localization resource
  * (style) removed dojo.string.substitute() calls for strings that
have no parameters to substitute
  * (required) added clauses to the build/i18n/Makefile to roundtrip
the pgt.js resource from JSON to POT and back

I also noticed that some strings still needed to be i18n-ized in
perm_list.html, but I'll deal with those separately. Otherwise, I have
applied the patch. Thanks very much for the patch!

-- 
Dan Scott
Laurentian University