[OPEN-ILS-DEV] PATCH: minor bug in myopac.js

[Jeff Godin]

Hello-

Noticed in 1.4.0.2, confirmed in trunk, the myopac.xml "My Account"
display doubles the patron's first given name:

Administrator Administrator System Account

myopac.js was the culprit, populating the "prefix" with the value of
first_given_name.

One line patch attached, DCO inline below.

-jeff


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Jeff Godin <jeff at tcnet.org>
-------------- next part --------------
Index: Open-ILS/web/opac/skin/default/js/myopac.js
===================================================================
--- Open-ILS/web/opac/skin/default/js/myopac.js	(revision 12318)
+++ Open-ILS/web/opac/skin/default/js/myopac.js	(working copy)
@@ -801,7 +801,7 @@
 	var iv1 = user.ident_value()+'';
 	if (iv1.length > 4) iv1 = iv1.replace(new RegExp(iv1.substring(0,iv1.length - 4)), '***********');
 
-	appendClear($('myopac_summary_prefix'),text(user.first_given_name()));
+	appendClear($('myopac_summary_prefix'),text(user.prefix()));
 	appendClear($('myopac_summary_first'),text(user.first_given_name()));
 	appendClear($('myopac_summary_middle'),text(user.second_given_name()));
 	appendClear($('myopac_summary_dayphone'),text(user.day_phone()));