[OPEN-ILS-DEV] Fixing the mixed-content warnings in My Account

Jeff Godin jeff at tcnet.org
Tue Jun 2 09:43:16 EDT 2009


On Tue, Jun 2, 2009 at 8:25 AM, Mike Rylander <mrylander at gmail.com> wrote:
>>
>> Not addressed yet: OILS_OPAC_IMAGES_HOST, or Craftsman.
>>
>
> Have you looked as the cost of addressing these?  If those can be
> taken care of in short order, I think this is the right way to go
> short-term, because it's less overall change the the code than and
> other options.

Yes. Attached is a patch that addresses the images host, craftsman
(tested, actually doesn't need anything special), and also implements
the "fallback to https".

So, out of the box there are no more mixed-content warnings, and
people with static servers can pick between the current "force HTTP"
with mixed-content warnings, or a new option to fallback to the https
servers for static content on https pages.

I hope this helps -- eg_vhost.conf has comments that attempt to
explain everything, please feel free to modify/enhance.

Thanks!

-jeff
-------------- next part --------------

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Jeff Godin <jeff at tcnet.org> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix-https-mixed-content-rev3.diff
Type: text/x-diff
Size: 4039 bytes
Desc: not available
Url : http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20090602/56f0fc00/attachment-0001.diff 


More information about the Open-ils-dev mailing list