[OPEN-ILS-DEV] MFHD Patch - Third Try

[David Fiander]

Dan,

Thanks. This is what I did, and everything's checked in.

- David

On Sat, Nov 21, 2009 at 7:15 PM, Dan Wells <dbw2 at calvin.edu> wrote:
> Hello David,
>
> As another alternative, if you don't want to bother with installing OpenSRF, it seems likely that this OpenSRF dependency will be removed soon for portability reasons anyway.  Because generate_predictions() is the end-of-the-line (so to speak), you can safely comment out from MFHD.pm the 'use OpenSRF...' line and the single call to perl2JSON near the bottom and none of the other internals will be affected, allowing the tests to complete normally.
>
> Dan
>
>>>> On 11/21/2009 at 5:54 PM, Dan Scott <dan at coffeecode.net> wrote:
>> On Sat, 2009-11-21 at 13:38 -0500, David Fiander wrote:
>>> > I'll just do a quick check, and then apply this later today.
>>>
>>> Whoops. I spoke too soon. Dan, when I try to run my regression test
>>> suite agains the patched code, the load fails because it can't find
>>> OpenSRF/Utils/JSON.pm.
>>>
>>> Since I never use OpenSRF, I don't have that checked out or installed
>>> on my system. I'm willing to check it out into my development
>>> environment, but can you give me a hint as to how you think
>>> MFHD/test/Makefile should be edited to eliminate this problem?
>>>
>>> - David
>>
>> Given a checkout of OpenSRF into ~/OpenSRF, the following works here:
>>
>> PERL5LIB=~/OpenSRF/src/perl/lib/:$PERL5LIB make
>>
>> The only dependency appears to be the JSON::XS module.
>>
>> Hope it works for you!
>
>