[OPEN-ILS-DEV] ***SPAM*** Re: ***SPAM*** Re: Export to RefWorks in Evergreen

[Dan Scott]

2009/8/5 Warren Layton <warren.layton at gmail.com>:
> Hi Dan
>
> On Fri, Jul 31, 2009 at 11:32 AM, Dan Scott<denials at gmail.com> wrote:
>> One problem in reading the patch: you've introduced a new entity, but
>> there's no corresponding diff for opac.dtd.
>>
>> A minor nit is that the existing code in the context of your changes
>> uses tabs, and you've got spaces.
>>
>> An aside: at some point, we're going to have to consolidate all of the
>> per-skin config vars into a single file.
>>
>> If you resubmit the patch, can you include the DCO as well?
>
>
> All fair points. Hopefully the issues with tabs-vs-spaces is addressed
> in the updated patch (attached), as well as the new entity in
> opac.dtd. If there's anything else, please let me know.
>
> Also, here's the DCO:
>
> Developer's Certificate of Origin 1.1
>
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
>    have the right to submit it under the open source license
>    indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
>    of my knowledge, is covered under an appropriate open source
>    license and I have the right under that license to submit that
>    work with modifications, whether created in whole or in part
>    by me, under the same open source license (unless I am
>    permitted to submit under a different license), as indicated
>    in the file; or
>
> (c) The contribution was provided directly to me by some other
>    person who certified (a), (b) or (c) and I have not modified
>    it.
>
> (d) I understand and agree that this project and the contribution
>    are public and that a record of the contribution (including all
>    personal information I submit with it, including my sign-off) is
>    maintained indefinitely and may be redistributed consistent with
>    this project or the open source license(s) involved.
>
> Signed-off-by: Warren Layton

I'm embarrassed at how long it has taken to do this, but happy to
report that I have tested your patch successfully and applied it
against trunk and the rel_1_6 branch, with just one minor change: as
with the "Export to RefWorks" for an individual record, I have set the
default behaviour to not display the link. Sites that want to enable
this functionality will need to adjust
/openils/var/web/opac/skin/default/js/myopac.js accordingly.

Thanks so much, Warren; this will be very useful for the Conifer
libraries, and undoubtedly many other libraries as well!

Dan