[OPEN-ILS-DEV] ***SPAM*** Conify Hours of Operation (Patch)

[Mike Rylander]

Warren, the patch looks good, and openils.PermaCrud is indeed the way to go.

Applied and backported, thanks!

--miker

On Wed, Aug 5, 2009 at 11:57 AM, Warren Layton <warren.layton at gmail.com> wrote:
> There was some discussion on IRC a while ago about problems editing
> hours of operation, and (in my case, at least), I found that adding
> and deleting org units was a problem, too. Attached is a patch for the
> Conify interface in trunk that appears to fix these issues for me.
>
> This is my first foray into pcrud (not to mention Dojo...), so feel
> free to kick this back for further development if there are any
> problems. I'm a bit unsure of the code under the "onerror" and
> "oncomplete" conditions, which I have pretty much left intact. I have
> also used the Dojo "openils.PermaCrud" instead of the OpenSRF
> "open-ils.pcrud", which may or may not be the correct way to go.
>
> Feedback is definitely welcome, and I'd be willing to have a look at
> the code for addresses (mailing, ILL, etc) once I'm sure I'm on the
> right track with this current patch.
>
> Cheers,
>  Warren Layton
>  NRCan Library
>
>
> Developer's Certificate of Origin 1.1
>
> By making a contribution to this project, I certify that:
>
> (a) The contribution was created in whole or in part by me and I
>    have the right to submit it under the open source license
>    indicated in the file; or
>
> (b) The contribution is based upon previous work that, to the best
>    of my knowledge, is covered under an appropriate open source
>    license and I have the right under that license to submit that
>    work with modifications, whether created in whole or in part
>    by me, under the same open source license (unless I am
>    permitted to submit under a different license), as indicated
>    in the file; or
>
> (c) The contribution was provided directly to me by some other
>    person who certified (a), (b) or (c) and I have not modified
>    it.
>
> (d) I understand and agree that this project and the contribution
>    are public and that a record of the contribution (including all
>    personal information I submit with it, including my sign-off) is
>    maintained indefinitely and may be redistributed consistent with
>    this project or the open source license(s) involved.
>
> Signed-off-by: Warren Layton <warren.layton at googlemail.com>
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com