[OPEN-ILS-DEV] JSON: retire old parser?

[Dan Scott]

On Fri, 2010-08-13 at 10:30 -0400, Bill Erickson wrote:
> 
> 
> On Fri, Aug 13, 2010 at 10:04 AM, Scott McKellar <mck9 at swbell.net>
> wrote:
>         The file osrf_json_parser.c implements a JSON parser that we
>         don't use any more.  Is there any objection to getting rid of
>         it?
<snip>
>         Accordingly I propose to remove osrf_json_parser.c from the
>         Makefiles, and remove its function prototypes from the
>         relevant header files.  We don't need to remove it from the
>         repository; we can keep it around as a historical relic,
>         though we should probably add a prominent comment pointing out
>         its defunctness.
> 
> +1

+1

> 
> I don't see any need to keep it around, since the files live on in the
> repository history.

+1
 
>         
>         Another question is one of timing: should we include these
>         changes in v2.0?  I don't greatly care one way or the other,
>         myself.  The old dead code is harmless enough, apart from the
>         clutter and the potential for confusion.  I could understand a
>         reluctance to make unnecessary changes just before a major
>         release.
> 
> 
> These are the options I see
> 
> 1. Evergreen 2.0 uses OpenSRF 1.4 (chunking, parser removal, and
> possibly net-server gutting go into 1.6)
> 
> 2. Evergreen 2.0 uses OpenSRF 1.6 (w/ chunking)
> 
> 3. Evergreen 2.0 uses OpenSRF 1.6 (w/ chunking and removal of dead
> JSON parser)

I'm in favour of the last option. I'm not sure that OpenSRF 1.4 has even
seen any sustained use in real-life situations since I cut the 1.4.0
release, so going with 1.4 could actually be riskier than going with 1.6
(where we have at least been running it in development).

Getting further out on the limb - were there any results from the Perl
pre-forking server experiment
(http://markmail.org/thread/5wgupxajv7625yme )? Jason Stephenson had
offered to test it out, but I haven't heard any reports back from him or
anyone else. I would be really interested in seeing that get into
OpenSRF. For the risk-averse, we could branch 1.6 after the removal of
the dead JSON parser and immediately check the Perl pre-forker into
trunk.