[OPEN-ILS-DEV] Spidermonkey Threadsafe Patch

[Thomas Berezansky]

Appears to work....still on 64 bit Ubuntu though. We aren't running  
any 32 bit versions that I know of to test that with. Thanks for  
taking a look at it.

Thomas Berezansky
Merrimack Valley Library Consortium


Quoting Dan Scott <dan at coffeecode.net>:

> On Wed, 2010-07-28 at 17:27 -0400, Thomas Berezansky wrote:
>> I don't know if anyone else has this issue, but we do and at least one
>> of the other locations we are working with does.
>>
>> The issue is that SpiderMonkey won't build and test with the
>> -JS_THREADSAFE option specified on any x64 Ubuntu version I have used.
>>
>> The two attached patches attempt to resolve this, but do so slightly
>> differently. The threadsafe patch file adds an option to turn the
>> threadsafe option on, defaulting it to off. The nothreadsafe option
>> adds an option to turn the threadsafe option off, defaulting it to on.
>>
>> Technically the nothreadsafe patch keeps the current default behavior,
>> but I think the threadsafe patch is the better way of doing it.
>
> Thanks for reporting this problem, Thomas. I took a different approach
> to solving it in r17052
> (http://svn.open-ils.org/trac/ILS/changeset/17052) - I tackled the
> problem of why JavaScript::SpiderMonkey wasn't building with the
> -JS_THREADSAFE option.
>
> It turned out that libjs was not being compiled with its own
> JS_THREADSAFE option. Once I turned that on, and resolved some
> dependencies (getting the nspr4 headers into the includes), that made
> libjs happy and threadsafe, and also enabled JavaScript::SpiderMonkey
> to compile with -JS_THREADSAFE.
>
> As noted in the commit comment, I tested with 64-bit Ubuntu and 64-bit
> Debian Lenny. I didn't need to test with 64-bit Fedora 13 because it
> offers a packaged threadsafe version of libjs.
>
> Confirmation that this actually works would be much appreciated!
>
>