[OPEN-ILS-DEV] ***SPAM*** Re: Suggested Patch: Block Renews for Holds

[Mike Rylander]

On Thu, Mar 11, 2010 at 5:14 PM, Jason Stephenson <jstephenson at mvlc.org> wrote:
> Quoting Dan Wells <dbw2 at calvin.edu>:
>
>> Hello again,
>>
>> Attached you will now find two versions of the patch, one for rel_1_6_0
>> and one for trunk.  The rel_1_6_0 version only differs from the first
>> version in adding a new matching permission to the data seed file.  The
>> trunk version populates the config.org_unit_setting_type table rather than
>> the org_unit_settings.xhtml file.  I have less confidence in the trunk
>> version due to lack of experience, and the permissions table adds should be
>> double-checked in both cases, as trunk and rel_1_6_0 populate these tables
>> quite differently.
>
> We have loaded our test environment with trunk revision 15774 and applied
> Dan's patch as this is a functionality that I know will interest some of our
> members. We'll share with Dan and the list any comments/changes that come
> from our testing.
>

I'm in patch application mode today ... Jason, do you have any
feedback +/- on this?  TIA

--miker

> Jason Stephenson
> Merrimack Valley Library Consortium
>
>
>>
>> Thanks,
>> Dan
>>
>>>>> On 3/10/2010 at 1:26 PM, Dan Wells<dbw2 at calvin.edu> (Dan Wells) wrote:
>>>
>>> Hello all,
>>>
>>> The attached patch is a very simple means of allowing an option for the
>>> blocking of renews if an item is targeted for a hold.  There was some
>>> discussion on IRC about the 'best' way to do this, but other ways (in my
>>> opinion) ended up as just too far-reaching for what should be a simple
>>> feature.
>>>
>>> This is tested and in production at our in-db-circ site, but I think it
>>> will
>>> work for script-based-circ as well.  The patch targets rel_1_6_0.
>>>
>>> Thanks,
>>> Dan
>>>
>>> =============================================
>>> Developer's Certificate of Origin 1.1
>>>
>>> By making a contribution to this project, I certify that:
>>>
>>> (a) The contribution was created in whole or in part by me and I
>>>   have the right to submit it under the open source license
>>>   indicated in the file; or
>>>
>>> (b) The contribution is based upon previous work that, to the best
>>>   of my knowledge, is covered under an appropriate open source
>>>   license and I have the right under that license to submit that
>>>   work with modifications, whether created in whole or in part
>>>   by me, under the same open source license (unless I am
>>>   permitted to submit under a different license), as indicated
>>>   in the file; or
>>>
>>> (c) The contribution was provided directly to me by some other
>>>   person who certified (a), (b) or (c) and I have not modified
>>>   it.
>>>
>>> (d) I understand and agree that this project and the contribution
>>>   are public and that a record of the contribution (including all
>>>   personal information I submit with it, including my sign-off) is
>>>   maintained indefinitely and may be redistributed consistent with
>>>   this project or the open source license(s) involved.
>>>
>>> Signed-off-by: Daniel B. Wells
>>> =============================================
>>>
>>>
>>
>>
>
>
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com