[OPEN-ILS-DEV] check_null patch

[Thomas Berezansky]

Don McMorris commented on the check_null script as being a bit of a  
hack that was pounded on until it worked in the Massachusetts Library  
Network Cooperative session. I took a look afterward and decided to  
give a bit of a rewrite a try.

I have attached a patch file, but have not been able to test it in  
full due to our test system not having any significant logging set up  
yet. Still, some partial tests make me think it works fine.

My rewrite tries to avoid some of the looping over the same logfile  
multiple times, adds in a pile of checking of options and such, and  
should fix the problem of not getting proper counts across midnight  
mentioned in the comments on the original.

Thomas Berezansky
Merrimack Valley Library Consortium




-------------- next part --------------
A non-text attachment was scrubbed...
Name: check_null.patch
Type: text/x-patch
Size: 4588 bytes
Desc: not available
Url : http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20100505/bfe756f6/attachment-0001.bin 
-------------- next part --------------
Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Thomas Berezansky <tsbere at mvlc.org>