[OPEN-ILS-DEV] check_null patch

[Don McMorris]

Committed as changeset 884 to ILS-Contrib.  Thanks again!

http://svn.open-ils.org/trac/ILS-Contrib/changeset/884/ESI-Examples/sys/lib/nagios-plugins/check_null

--Don

On Thu, May 6, 2010 at 3:05 PM, Don McMorris <don.mcmorris at gmail.com> wrote:
> Thanks Thomas.  It looks like you hit a number of the changes I've
> been wanting to do.  A bit of history of that script... I developed it
> very early on in my experience, and didn't have much familiarity with
> the 'date' command (ex: blah minutes ago).
>
> I'll get this tested ASAP, and when I find it to work I'll update the
> file in the ILS-Contrib/ESI-Examples repo.
>
> Thanks!
> --Don
>
> On Wed, May 5, 2010 at 5:02 PM, Thomas Berezansky <tsbere at mvlc.org> wrote:
>> Don McMorris commented on the check_null script as being a bit of a hack
>> that was pounded on until it worked in the Massachusetts Library Network
>> Cooperative session. I took a look afterward and decided to give a bit of a
>> rewrite a try.
>>
>> I have attached a patch file, but have not been able to test it in full due
>> to our test system not having any significant logging set up yet. Still,
>> some partial tests make me think it works fine.
>>
>> My rewrite tries to avoid some of the looping over the same logfile multiple
>> times, adds in a pile of checking of options and such, and should fix the
>> problem of not getting proper counts across midnight mentioned in the
>> comments on the original.
>>
>> Thomas Berezansky
>> Merrimack Valley Library Consortium
>>
>>
>>
>>
>>
>