[OPEN-ILS-DEV] PATCH: Drop Schemas

Jason Stephenson jstephenson at mvlc.org
Thu May 20 16:23:54 EDT 2010


Hi,

The attached patch (with DCO) adds "IF EXISTS" after all DROP SCHEMA  
statements where it is currently missing in the scripts in  
Open-ILS/src/sql/Pg directory. The patch is generated against  
trunk/r16465.

A similar change could be made to 1.6 or earlier releases by running  
something like:

sed -r -e 's/(DROP SCHEMA) ([^[:upper:]])/\1 IF EXISTS \2/' -i *.sql

NOTE: Use -E instead of -r if using a BSD sed. The above is for GNU sed.

I thought of creating/submitting this patch after a new user noticed  
messages about non-existent schemas while running eg_db_config.pl.

I am all about getting rid of spurious warnings that don't serve any  
real purpose.

Cheers,
Jason Stephenson
Merrimack Valley Library Consortium
-------------- next part --------------
A non-text attachment was scrubbed...
Name: dropschema.patch
Type: text/x-patch
Size: 7343 bytes
Desc: not available
Url : http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20100520/435bbd04/attachment.bin 
-------------- next part --------------

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Signed-off-by: Jason Stephenson <jstephenson at mvlc.org>



More information about the Open-ils-dev mailing list