[OPEN-ILS-DEV] SIP Problem

[Bill Erickson]

atz++

I was thinking something along the lines this, but there may be a better
way.


diff --git a/Sip/MsgType.pm b/Sip/MsgType.pm
index e9176f9..81bb3b4 100644
--- a/Sip/MsgType.pm
+++ b/Sip/MsgType.pm
@@ -975,7 +975,8 @@ sub handle_patron_info {
         # Custom protocol extension to report patron internet privileges
         $resp .= maybe_add(FID_INET_PROFILE, $patron->inet_privileges);

-        $resp .= maybe_add(FID_PATRON_INTERNAL_ID, $patron->internal_id);
# another extension
+        $resp .= maybe_add(FID_PATRON_INTERNAL_ID, $patron->internal_id) #
another extension
+            if $patron->can('internal_id');

         $resp .= maybe_add(FID_SCREEN_MSG, $patron->screen_msg);
         $resp .= maybe_add(FID_PRINT_LINE, $patron->print_line);


On Thu, Nov 18, 2010 at 1:36 PM, Joe Atzberger <ohiocore at gmail.com> wrote:

> Still rebuilding my dev environment, but I'll patch SIPServer when it's up.
>
> --joe
>
>
> On Thu, Nov 18, 2010 at 9:45 AM, Bill Erickson <erickson at esilibrary.com>wrote:
>
>>
>> Hi John,
>>
>> In the short term, you can fix this by applying this patch to your local
>> install and restarting SIP:
>>
>> http://svn.open-ils.org/trac/ILS/changeset/17292
>>
>> I'll see about back-porting this change and submitting a patch to the SIP
>> Server repository to protect against this going forward.
>>
>> -b
>>
>>
>> On Thu, Nov 18, 2010 at 8:51 AM, John van Rassel <jvanrassel at innisfil.ca>wrote:
>>
>>> This is the error that comes up:
>>>
>>> Can't locate object method "internal_id" via package
>>> "OpenILS::SIP::Patron" at Sip/MsgType.pm line 978.
>>>
>>>
>>>
>>> Any advice on how to proceed?
>>>
>>>
>>>
>>> Thanks,
>>>
>>> John van Rassel
>>>
>>> Manager of Information Technology
>>>
>>> Innisfil Public Library
>>>
>>>
>>>
>>> *From:* open-ils-dev-bounces at list.georgialibraries.org [mailto:
>>> open-ils-dev-bounces at list.georgialibraries.org] *On Behalf Of *Bill
>>> Erickson
>>> *Sent:* Wednesday, November 17, 2010 3:26 PM
>>> *To:* Evergreen Development Discussion List
>>> *Subject:* Re: [OPEN-ILS-DEV] SIP Problem
>>>
>>>
>>>
>>>
>>>
>>> On Wed, Nov 17, 2010 at 2:42 PM, John van Rassel <jvanrassel at innisfil.ca>
>>> wrote:
>>>
>>> Hello all,
>>>
>>> I am trying to get SIP working under Evergreen 1.6.1.2.  I think I almost
>>> have it but it’s no quite there
>>>
>>> When I run the tests where it gets to the patron info tests it says:
>>>
>>> 02patron_info......ok 1/8FAILED--Further testing stopped: Read failure in
>>> valid Patron Info no details
>>>
>>>
>>>
>>> Does anyone have any ideas why this may be happening?
>>>
>>>
>>> Hi John,
>>>
>>> The SIP server is probably crashing on something.  A good debugging tool
>>> is to edit the oils_ctl.sh controller script (assuming that's how you start
>>> the SIP server) and redirect SIP errors to a log file instead of /dev/null.
>>>
>>>
>>>
>>>
>>> Change /dev/null to a real file that opensrf can write to in this line:
>>>
>>>
>>>
>>>     perl SIPServer.pm "$OPT_SIP_CONFIG" > /dev/null 2>&1 &
>>>
>>>
>>>
>>> Or you could just merge in this change from 2.0 which allows for a
>>> command line error log option:
>>>
>>>
>>>
>>> http://svn.open-ils.org/trac/ILS/changeset/17566
>>>
>>>
>>>
>>> Hope this helps.
>>>
>>


-- 
Bill Erickson
| VP, Software Development & Integration
| Equinox Software, Inc. / Your Library's Guide to Open Source
| phone: 877-OPEN-ILS (673-6457)
| email: erickson at esilibrary.com
| web: http://esilibrary.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20101118/e65e9b40/attachment.htm