[OPEN-ILS-DEV] Functions for updating the call number label or owning_lib associated with a copy

Galen Charlton gmc at esilibrary.com
Thu Apr 14 16:07:49 EDT 2011


Hi,

On Apr 14, 2011, at 2:54 PM, Dan Scott wrote:
> You snipped out the concerns I expressed about testing and maintaining
> these functions. Say what you will about the state of testing of the
> existing database functions, at least there's a chance that they will be
> exercised and deficiencies noted in day-to-day operation, as they are
> part of the general code. For the class of functions that Ben is
> proposing, however, I personally wouldn't want to see them become part
> of core unless there is a solid plan in place for documenting and
> testing and maintaining the functions; these seem much more likely to be
> susceptible to bitrot.

The routines in question are being actively used now, and would not stop being used just because they get added to core.  In fact, if they're sufficiently useful, they'll be tested more.  Even absent a formal test plan, it beats the status quo of a bunch of separate utility routines maintained by various Evergreen organizations.  But yeah, that isn't a substitute for a full test suite, so I'm work on a patch with some ideas towards fixing that.

Documentation?  Sure, there's no problem mandating that these be properly documented.

By the way, do you have any comments for Ben regarding the actual routine as proposed, regardless of where it gets placed?

Regards,

Galen
--
Galen Charlton
VP, Data Services
Equinox Software, Inc. / Your Library's Guide to Open Source
email:  gmc at esilibrary.com
direct: +1 352-215-7548
skype:  gmcharlt
web:    http://www.esilibrary.com/



More information about the Open-ils-dev mailing list