[OPEN-ILS-DEV] opensrf.js Unit Tests and Fix

[Bill Erickson]

Hi,

I've applied opensrf_js_fix.patch to OpenSRF trunk/2.0.

http://svn.open-ils.org/trac/OpenSRF/changeset/2235

In case there is any confusion how this code was working, from the commit
msg, "note, this does not currently affect behavior, since values for
messages are initially set from parsing JSON without using the
accessor/mutators for setting values." ... Or from setting fields directly
without using the methods.

Thanks for fixing this oversight, Kevin

-b


On Thu, Apr 14, 2011 at 3:53 PM, Kevin Beswick <kevinbeswick00 at gmail.com>wrote:

> Hello,
>
> Attached are two patches. The first one contains some unit tests for
> the first half of opensrf.js. These make use of the DOH (Dojo
> Objective Harness) framework that Dan Scott had put into place in this
> commit: http://svn.open-ils.org/trac/OpenSRF/changeset/2217/
>
> The second patch contains a fix for a bug I found in opensrf.js while
> writing the unit tests. There were references to arguments that
> weren't declared in several of the function declarations. Natually,
> many of the unit tests will not pass until this fix is put into place.
>
> Kevin Beswick
>



-- 
Bill Erickson
| VP, Software Development & Integration
| Equinox Software, Inc. / Your Library's Guide to Open Source
| phone: 877-OPEN-ILS (673-6457)
| email: erickson at esilibrary.com
| web: http://esilibrary.com
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20110428/aee87c31/attachment.htm