[OPEN-ILS-DEV] template toolkit master merge branch

[Mike Rylander]

On Aug 18, 2011 8:41 PM, "Thomas Berezansky" <tsbere at mvlc.org> wrote:
>
> Having taken a look at the merge branch I feel that it is not ready for
merging, in part due to the leftovers from the javascript opac that the
template toolkit pieces never touch.
>

Not sure I follow.  The goal isn't to replace the existing opac with the
initial merge, if that's what you mean.

--miker

> I can attempt some additional testing of it in regards to the lists issues
in the coming week, though.
>
> Thomas Berezansky
> Merrimack Valley Library Consortium
>
>
>
> Quoting Dan Scott <dan at coffeecode.net>:
>
>> For what it's worth, I was unable to reproduce the "My Lists" crashing
>> problem over the past few days with my local setup on my laptop (two
>> lists, one with 48 items, the other with 10 items). However, that was
>> with only 150 records in the database in total, so indexes wouldn't be
>> coming into play in that test configuration. [Insert standard "we
>> really need automated test environments that include large quantities
>> of data for testing these scenarios" statement here]
>>
>> I did find and fix a number of other (some rather glaring, but maybe
>> only due to the particular test data I was using) bugs in the merge
>> branch, though.
>>
>> My perspective on master is that we should not be merging anything to
>> master that we know is not production-ready; otherwise, the problems
>> that we know about at the time that something is merged tend to fade
>> into the background as higher priority / sexier work needs to be done,
>> and we end up having to retrace our steps (or other people's steps)
>> when it gets to release time (or worse, after). It's one of the core
>> principles of agile development - you should be comfortable with the
>> idea of cutting a fresh release from your core branches at any point
>> in time.
>>
>> On Mon, Aug 8, 2011 at 4:25 PM, Lebbeous Fogle-Weekley
>> <lebbeous at esilibrary.com> wrote:
>>>
>>> Right, I should be clear. I propose merging it into master; I am by no
means
>>> advocating it for production use.  When I say I haven't come across any
>>> features that don't work, I mean among features that did work in their
>>> original branches in the first place.
>>>
>>> Regarding database indexes, we probably should figure out what query in
>>> particular is causing the problem you're seeing, and see if it should be
>>> optimized or determine what indexes it might need.
>>>
>>> Does one need to have a lot more than one list to see this problem?  I
don't
>>> think I've had a problem with one or two, but I don't recall testing
more
>>> than that anytime recently.
>>>
>>> Lebbeous
>>>
>>> On 08/08/2011 04:18 PM, Jason Stephenson wrote:
>>>>
>>>>
>>>> Quoting Lebbeous Fogle-Weekley <lebbeous at esilibrary.com>:
>>>>
>>>>> Bill's merge seems to work well to me. I haven't come across any
>>>>> features that don't work in this branch. Let's do this!
>>>>
>>>>
>>>>
>>>> Specifically, I get the following when going to My Lists (I have more
>>>> than 1 list):
>>>>
>>>> [Mon Aug 08 16:14:06 2011] [error] [client 71.184.200.6] egweb: Context
>>>> Loader error: Exception: OpenSRF::EX::Session 2011-08-08T16:14:06
>>>> OpenILS::WWW::EGWeb
>>>> /usr/local/share/perl/5.10.1/OpenILS/WWW/EGWeb.pm:113 Session Error:
>>>>
>>>> opensrf at private.localhost
/open-ils.cstore_drone_jasondev_1312834165.382166_18468
>>>> IS NOT CONNECTED TO THE NETWORK!!!\n, referer:
>>>> https://jasondev.mvlcstaff.org/eg/opac/myopac/main
>>>>
>>>> Looks cstore drones are crashing, but I can find no indication of it in
>>>> the osrfsys.log. The drone is there when it receives the request and
>>>> then it is not there in the logs any longer.
>>>>
>>>> Could be we need some more database indexes?
>>>>
>>>> Jason
>>>>
>>>>
>>>>
>>>>>
>>>>> Lebbeous
>>>>>
>>>>> On 08/03/2011 12:28 PM, Bill Erickson wrote:
>>>>>>
>>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> As an action item from yesterday's IRC dev meeting, I've created a
>>>>>> template toolkit branch, up to date with master, that includes all
>>>>>> (known) template toolkit topic branches. Details are on the wiki at
>>>>>>
>>>>>>
http://evergreen-ils.org/dokuwiki/doku.php?id=dev:opac:template-toolkit:merge
.
>>>>>>
>>>>>> There were a few minor merge conflicts, so sanity checking by topic
>>>>>> branch owners would be appreciated. Testing, of course, is also
>>>>>> appreciated.
>>>>>>
>>>>>> A fresh install should be no different than a regular master install.
>>>>>> Notes for installing over an existing system are linked from the wiki
>>>>>> page.
>>>>>>
>>>>>> Thanks
>>>>>>
>>>>>> -b
>>>
>>>
>>>
>>> --
>>> Lebbeous Fogle-Weekley
>>>  | Software Developer
>>>  | Equinox Software, Inc. / Your Library's Guide to Open Source
>>>  | phone:  1-877-OPEN-ILS (673-6457)
>>>  | email:  lebbeous at esilibrary.com
>>>  | web:  http://www.esilibrary.com
>>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://libmail.georgialibraries.org/pipermail/open-ils-dev/attachments/20110818/729d3a73/attachment.htm>