[OPEN-ILS-DEV] BibTemplate and Opera Compatibility

[Mike Rylander]

On Tue, Feb 15, 2011 at 3:52 PM, Dan Wells <dbw2 at calvin.edu> wrote:
> Thanks for the feedback.  Attached is a patch against trunk with a couple of changes based on these suggestions.
>
> First, the quote removal code is integrated a little more cleanly and also now wrapped in a dojo.isOpera condition.  Second, the bib.documentElement is now directly inside the item_list query.  This preserves the XMLDocument in the 'bib' variable for later use in the code (callbacks?), and I don't think we lose any possible functionality, as the item_list already assumes we are querying for nodes (rather than using some other XMLDocument property).  This does, however, shift some onus of responsibility for maintaining Opera compatibility to any code which wants to query the 'bib' further down the line (not really a bad thing, just making note).
>
> Thoughts?
>

For the list ... Dan and I reworked this a bit in IRC and a version
has been committed to trunk, rel_2_1 and rel_2_0.

--miker

> Dan
>
>>
>> There was a need to add quotes around literals in queries for one
>> browser or another (Dan Scott attacked this, IIRC), so how about
>> replacing the if(1)s with if(dojo.isOpera), at least for the second
>> hunk in the patch?  For the documentElement part, there is value in
>> having access to the document object from within slot code (maybe not
>> a huge amount, but IMO it's not worth removing if we can avoid it), so
>> perhaps we need a separate variable to hold that and use it in
>> internal queries.  Thoughts?
>>
>> --miker
>>
>
>
>



-- 
Mike Rylander
 | VP, Research and Design
 | Equinox Software, Inc. / The Evergreen Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  miker at esilibrary.com
 | web:  http://www.esilibrary.com