[OPEN-ILS-DEV] Minor issues with 0752, 0753, and 0756

[Lebbeous Fogle-Weekley]

Hi Ben.

For 0752, I think a script that explicitly moves the function to
evergreen.is_json() in cases where it's public.is_json() once and for
all would be fine.

I pushed a documentation fix for 0753.

0756 may be harder to deal with.  I don't have any databases that old
to test with, but I agree with your plan.  Happy to assist if you
should need it.

Thanks,

Lebbeous

On Sat, Feb 16, 2013 at 5:16 AM, Ben Shum <bshum at biblio.org> wrote:
> Just noting some minor issues as I was worked through upgrading a copy of
> our production DB with the new upgrade scripts:
>
> 0752:  evergreen.is_json might be public.is_json on older upgraded
> databases; creating that as a new function or changing the script to allow
> for the old naming worked for me.  Still not sure how to deal with this
> issue for us.
>
> 0753:  encountered following error, easily resolved by adding Rose::URI on
> our separate DB server (maybe a new dependency we should note in the README
> for extra modules that need to be installed for separate DB):
>
> psql:0753.functions.url_verify.sql:21: ERROR:  Can't locate Rose/URI.pm in
> @INC (@INC contains: /etc/perl /usr/local/lib/perl/5.10.1
> /usr/local/share/perl/5.10.1 /usr/lib/perl5 /usr/share/perl5
> /usr/lib/perl/5.10 /usr/share/perl/5.10 /usr/local/lib/site_perl .) at line
> 3.
>
> 0756:  search.staged_fts ?
>
> psql:0756.drop.query_parser_fts.sql:6: ERROR:  cannot drop type
> search.search_result because other objects depend on it
> DETAIL:  function
> search.staged_fts(integer,integer,text,integer[],integer[],text[],text[],text[],text[],text[],text[],text[],text,text,text,text[],text,real,text,boolean,boolean,boolean,integer,integer,integer)
> depends on type search.search_result
> HINT:  Use DROP ... CASCADE to drop the dependent objects too.
>
> This one was fun to track down.  It looks like there's an old commit to
> remove it from the schema back in June 2010 but never an upgrade script to
> perform the action.  See:
> http://git.evergreen-ils.org/?p=Evergreen.git;a=commit;h=415e0c40cf8ac0fbba91541f9ddf386d02f01fec
>
> Since we were in the middle of the 1.6.0 series in June 2010 and we started
> Evergreen as a 1.6.0 site, I guess these remnant functions have finally
> caught up to us.  So it looks like we need to remove both search.staged_fts
> and search.parse_search_args from old Evergreen systems as part of the
> upgrade action.
>
> I'll try wrapping all this up into a branch later this weekend if nobody
> beats me to it; just wanted to note these issues so that I didn't forget
> about them.
>
> -- Ben
>
> --
> Benjamin Shum
> Open Source Software Coordinator
> Bibliomation, Inc.
> 32 Crest Road
> Middlebury, CT 06762
> 203-577-4070, ext. 113
>



--
Lebbeous Fogle-Weekley
 | Software Developer
 | Equinox Software, Inc. / The Open Source Experts
 | phone:  1-877-OPEN-ILS (673-6457)
 | email:  lebbeous at esilibrary.com
 | web:  http://www.esilibrary.com