[OPEN-ILS-DEV] Evergreen 2.5.2 makefile patch

[Sharp, Chris]

Paul,

Thanks for finding that - great detective work!  I'll take responsibility for that oversight, since I was the one to put that script together.  (Though I tested the lucid install on a VM at the time and didn't see the issue, I didn't do a *lot* of testing beyond seeing that the Makefile.install script finished without an error).

I will mention that lucid almost didn't make the per-distro "Makefile.install" cut, since technically we support the most current Ubuntu LTS version, but since we had most of the workings for lucid already created, and one of our sites indicated that they are still using lucid, I decided to include it in my efforts.  For good measure, I'll recommend that you run on Ubuntu 12.04 if that's possible for you.  As soon as 14.04 is released this April, we will be removing support for 10.04 altogether.

For submitting the patch, see http://wiki.evergreen-ils.org/doku.php?id=dev:git for guidelines/instructions.  If you would rather someone else submit the patch on your behalf, you can request that too.

Thanks for the catch!

Chris


----- Original Message -----
> From: "Paul Hoffman" <paul at flo.org>
> To: open-ils-dev at list.georgialibraries.org
> Sent: Friday, February 7, 2014 3:43:58 AM
> Subject: [OPEN-ILS-DEV] Evergreen 2.5.2 makefile patch
> 
> I got stuck on a new Evergreen 2.5.2 installation on an Ubuntu 10.04
> server (ubuntu-lucid) and have found what appears to be a bug in
> Open-ILS/src/extras/install/Makefile.ubuntu-lucid.  I was following
> the
> instructions (http://.../README_2_5.html) and hit an error when
> running
> ./configure as shown in section 4:
> 
> # su paul
> $ PATH=/openils/bin:$PATH ./configure --prefix=/openils
> --sysconfdir=/openils/conf
> [...]
> checking for dlopen in -ldl... yes
> checking for dbi_initialize in -ldbi... no
> checking for libdbi pgsql driver (dynamic load)... configure: error:
> in `/usr/local/src/Evergreen-ILS-2.5.2':
> configure: error: "pgsql driver not installed?"
> See `config.log' for more details
> 
> After a certain amount of flailing about -- I'll spare you the
> embarrassing details -- I noticed that Makefile.ubuntu-lucid didn't
> actually attempt to build the install_libdbi target in
> Makefile.common.
> I added it there and continued the install and that seemed to do the
> trick:
> 
> ------------ >8 ------------ >8 ------------ >8 ------------ >8
> ------------
> ---
> Evergreen-ILS-2.5.2/Open-ILS/src/extras/install/Makefile.ubuntu-lucid
>       2014-01-16 16:11:29.000000000 -0500
> +++
> Evergreen-ILS-2.5.2.flo/Open-ILS/src/extras/install/Makefile.ubuntu-lucid
>   2014-02-07 03:11:22.667919181 -0500
> @@ -95,6 +95,7 @@
>         make -f $(DIR)/Makefile.common install_cpan_force
>         make -f $(DIR)/Makefile.debian install_js_sm
>         make -f $(DIR)/Makefile.debian debian_sys_config
> +       make -f $(DIR)/Makefile.common install_libdbi
>  
>  install_yaz:
>         if [ ! -d $(YAZ) ]; then wget $(YAZ_HOST)/$(YAZ).tar.gz; fi;
> ------------ >8 ------------ >8 ------------ >8 ------------ >8
> ------------
> 
> Naturally, I assume someone else has already found this -- I'm not
> pulling from the git repo yet -- but it gives me a warm feeling
> nonetheless.
> 
> Paul.
> 
> --
> Paul Hoffman <paul at flo.org>
> Systems Librarian
> Fenway Libraries Online
> c/o Wentworth Institute of Technology
> 550 Huntington Ave.
> Boston, MA 02115
> (617) 442-2384 (FLO main number)
> 

-- 
Chris Sharp
PINES System Administrator
Georgia Public Library Service
1800 Century Place, Suite 150
Atlanta, Georgia 30345
(404) 235-7147
csharp at georgialibraries.org
http://pines.georgialibraries.org/