[OPEN-ILS-DEV] Github pull requests - acceptable method?

[Josh Stompro]

Thanks Galen, I'll remember the DCO in the future, although I think I've said that before.  I'll also try to bunch my commits together into one pull request next time.

Signed-off-by: Josh Stompro <Stomproj at larl.org>
I accept the DCO for the following commits
46d51a43214582137570a382ac3e764a381a65e0
bde440cbd59ba7e521903a18b399a6c1545595a6
9f8c28cb70ed824d5e32295f87a72515c65a55ad
cda845df37ff12a4e2a6794883542de126f1014f

Josh

-----Original Message-----
From: open-ils-dev-bounces at list.georgialibraries.org [mailto:open-ils-dev-bounces at list.georgialibraries.org] On Behalf Of Galen Charlton
Sent: Wednesday, May 21, 2014 3:41 PM
To: Evergreen Development Discussion List
Subject: Re: [OPEN-ILS-DEV] Github pull requests - acceptable method?

Hi Josh,

On Wed, May 21, 2014 at 1:08 PM, Josh Stompro <stomproj at exchange.larl.org> wrote:
> I created a few pull requests in the past day, and then I noticed that 
> there are many old open pull requests on github, so maybe that isn’t a 
> supported method of contributing.
>
> https://github.com/evergreen-library-system/Evergreen/pulls?direction=
> desc&page=1&sort=created&state=open

It is supported, particularly for documentation changes, but not frequently used, though our documenters recently are encouraging more use of it it because of GitHub's ability to do inline editing.

I've glanced at your requests, and they all look good.  However, there's one administrative detail that would help.  Specifically, in the commit message, could you add a line that's of the form:

Signed-off-by: Josh Stompro <youremailaddress>

This signifies acceptance of Evergreen's Developer's Certificate of Origin (http://wiki.evergreen-ils.org/doku.php?id=dev:standing_dco),
which basically confirms that the patch was written by you and that you have permission to contribute it.

For your current pull requests, you can also reply with a statement accepting the DCO for them, and I can merge your commits and add your signoff.

We also run a project Git server; instructions for getting access to working repositories there can be found at

http://wiki.evergreen-ils.org/doku.php?id=dev:git

Regards,

Galen
--
Galen Charlton
Manager of Implementation
Equinox Software, Inc. / The Open Source Experts
email:  gmc at esilibrary.com
direct: +1 770-709-5581
cell:   +1 404-984-4366
skype:  gmcharlt
web:    http://www.esilibrary.com/
Supporting Koha and Evergreen: http://koha-community.org & http://evergreen-ils.org