[OPEN-ILS-DEV] QA proposals

[Dan Wells]

Hello all,

I definitely support requiring tests for *new features*, but I do have some concerns that proposal [2] will have a dampening effect on getting bugs fixed.  I understand the thinking that bug fixes sometimes cause more bugs, but I also think we also need to somehow incentivize bug fixes (being already unglamourous), and this policy makes it that much harder.  I still don't directly oppose the policy, especially since I do not have any great ideas to address this.

To make this more than abstract, we at Calvin have perhaps 10 or 20 smallish bug fixes in our local repository.  It is a constant struggle to justify to our staff the time it is going to take me to get these into LaunchPad.  If we're expected to also write tests, the timeline for getting these into LP probably just went from within 6 months to within 2 years, and maybe that is too generous.

So, if we are adopting [2], I think we need to be careful to not marginalize or otherwise discourage sharing branches without tests, as that still gets us one step closer to where we need to be.  Ideally we might find some people willing to specialize in test writing, and perhaps someday our tests will be so comprehensive that many bug fixes won't need a totally new test, but neither outcome seems imminent at this time.

Sincerely,
Dan

________________________________________
From: Open-ils-dev <open-ils-dev-bounces at list.georgialibraries.org> on behalf of Galen Charlton <gmc at esilibrary.com>
Sent: Wednesday, July 15, 2015 12:25 PM
To: Evergreen Development Discussion List
Subject: Re: [OPEN-ILS-DEV] QA proposals

Hi,

On Wed, Jul 15, 2015 at 12:18 PM, Kathy Lussier <klussier at masslnc.org> wrote:
> Are these guidelines official now?

As no objections were expressed... they are now.

> If so, I would like to update some wiki pages to reflect the new
> requirements:
>
> http://wiki.evergreen-ils.org/doku.php?id=contributing
> http://wiki.evergreen-ils.org/doku.php?id=dev:signoff_review_checklist

Thanks!

Regards,

Galen
--
Galen Charlton
Infrastructure and Added Services Manager
Equinox Software, Inc. / The Open Source Experts
email:  gmc at esilibrary.com
direct: +1 770-709-5581
cell:   +1 404-984-4366
skype:  gmcharlt
web:    http://www.esilibrary.com/
Supporting Koha and Evergreen: http://koha-community.org &
http://evergreen-ils.org