[OPEN-ILS-DEV] EVG 3.3.x, SIP and holds/checkouts being fleshed

[Ryan Eby]

Hi All, 

We recently upgraded from 3.0.2 to 3.3.5 and noticed some performance issues with SIP logins. Some background: 

- We only use SIP for overdrive logins, no self-checks 
- We have multiple patrons with title holds and checkouts in the hundreds (we don't limit)

Since the upgrade, it seems like when a patron does a login via SIP that the titles are fleshed out even for simple logins. The problem is Overdrive times out before patrons with hundreds of checkouts are fleshed out. 

>From digging into the code this seemed to come with the addition of renew_all in SIP but I am probably wrong. The part that seems to get hit is charged_items_impl. I've gotten around it for now by returning the charge ids regardless and not continuing to the fleshing circs code.

https://git.evergreen-ils.org/?p=Evergreen.git;a=blob;f=Open-ILS/src/perlmods/lib/OpenILS/SIP/Patron.pm;h=98a594da84df643319e3554492593e87a6fff4b4;hb=HEAD#l827

I was wondering if I'm missing some sort of configuration setting that would limit the SIP login code to just verifying the account is in good standing but not fleshing out all the display data. It seems like in the code there are options to have a slim user but I haven't been able to figure out how to trigger it. 

In our oils_sip.xml :

- All our policies stanza for the institution are false
- For supports stanza the login, patron information, end patron session, patron status request are true. The rest are false.

Ryan Eby