[OPEN-ILS-GENERAL] apostrophe in title search causing problems(Bug #744513)

[Gordana Vitez]

Hi everyone,

Thanks to all for providing information and feedback. The patch has been applied successfully for the libraries of the Niagara Evergreen Consortium.

Don't you just love it when things work so well, so quickly?!?

Thanks again!
Gordana

>>> Dan Scott <dan at coffeecode.net> 7/19/2011 1:27 PM >>>
On Tue, Jul 19, 2011 at 1:04 PM, Dan Wells <dbw2 at calvin.edu> wrote:
> Hello Gordana,
>
> This was a skin level fix, so since you are using a custom skin ('nc'), it must be applied manually to your skin after upgrading.  Since the fix is simply deleting a single line, it should be pretty simple to take care of.  See here to view the actual change needed:
>
> http://git.evergreen-ils.org/?p=Evergreen.git;a=blobdiff;f=Open-ILS/web/opac/skin/default/js/adv_global.js;h=897b1ea057cac0fc7b1c022c34e654ce2efe9dcf;hp=a6311b7ccdb76a85232a8f006eea08ff6971b21a;hb=04a9a2aaf7d17ce84a78ddf132fdb20486aa4218;hpb=f466fd7c66570af8f80e8ee085ff9c945aee8ffd 
>
> Note, though, that there may be other skin fixes between 2.0.2 and 2.0.7, so you may want to be more systematic about looking at all the 'default' skin changes from 2.0.2 to 2.0.7 and applying them to your custom skin.

Yep, and the Niagara skin currently includes in line 310 of adv_global.js:

 string = string.replace(/'/g,' ');

... which is what is introducing the space-instead-of-an-apostrophe
problem in the advanced search.