[OpenSRF-GIT] OpenSRF branch master updated. 9028b0238106923a64534b88eb6382bf59783ea5

[Evergreen Git]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenSRF".

The branch, master has been updated
       via  9028b0238106923a64534b88eb6382bf59783ea5 (commit)
      from  e203c6edd4e02437a56d98f24a7b8c52b142faee (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 9028b0238106923a64534b88eb6382bf59783ea5
Author: Galen Charlton <gmc at esilibrary.com>
Date:   Thu Sep 12 12:37:57 2013 -0700

    LP#1224647: remove two invalid tests
    
    The patch for bug 1204123 changes the client_recv()
    to not set the transport_client error flag, as most
    of the circumstances where it would have been set were
    for cases where the call to select() was interrupted
    by a signal, which is not an error per se.
    
    This patch removes two tests that were therefore
    made invalid, restoring the ability of the test suite
    to pass.
    
    Signed-off-by: Galen Charlton <gmc at esilibrary.com>
    Signed-off-by: Bill Erickson <berick at esilibrary.com>

diff --git a/tests/check_transport_client.c b/tests/check_transport_client.c
index 741263f..0373290 100644
--- a/tests/check_transport_client.c
+++ b/tests/check_transport_client.c
@@ -155,8 +155,6 @@ START_TEST(test_transport_client_recv)
   transport_message *msg2 = client_recv(other_client, -1);
   fail_unless(msg2 == NULL,
       "client_recv should return NULL if the call to session_wait() returns an error");
-  fail_unless(other_client->error == 1,
-      "client_recv should set client->error to true if an error has occured");
 
   //message in queue with no timeout
   transport_message *msg3 = client_recv(a_client, -1);
@@ -190,8 +188,6 @@ START_TEST(test_transport_client_recv)
   transport_message *msg5 = client_recv(other_client, 1); //only 1 sec again...
   fail_unless(msg5 == NULL,
       "client_recv should return NULL if there is an error");
-  fail_unless(other_client->error == 1,
-      "client_recv should set client->error to 1 if there is an error");
 END_TEST
 
 START_TEST(test_transport_client_free)

-----------------------------------------------------------------------

Summary of changes:
 tests/check_transport_client.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)


hooks/post-receive
-- 
OpenSRF