[OpenSRF-GIT] OpenSRF branch rel_2_5 updated. osrf_rel_2_5_0-18-g2bc1ff7
Evergreen Git
git at git.evergreen-ils.org
Fri Sep 15 09:46:08 EDT 2017
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "OpenSRF".
The branch, rel_2_5 has been updated
via 2bc1ff76ded6967ebc4a7e469d93ee4f614d736e (commit)
via e82b9edd077058b252e9e64bccf4fffb0a4fe29e (commit)
via ff0e2ba7fe2247575ab4f545f90a297fe2f56439 (commit)
from e7eee4bd383797c3cf7f99ec4da1b9bdcf4c94e0 (commit)
Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.
- Log -----------------------------------------------------------------
commit 2bc1ff76ded6967ebc4a7e469d93ee4f614d736e
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date: Fri Sep 15 10:02:32 2017 -0400
update ChangeLog for 2.5.2
Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
diff --git a/ChangeLog b/ChangeLog
index 0db07a8..7b5c323 100644
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,8 +1,8 @@
-commit 7e8571b44ffaca74b89d8b53e8ef45ff8b7d6744
+commit e82b9edd077058b252e9e64bccf4fffb0a4fe29e
Author: Galen Charlton <gmc at equinoxinitiative.org>
-Date: Mon Sep 11 17:23:52 2017 -0400
+Date: Fri Sep 15 10:01:33 2017 -0400
- update version stamp for 2.5.1
+ update version stamps for 2.5.2
Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
@@ -11,200 +11,39 @@ Date: Mon Sep 11 17:23:52 2017 -0400
1 1 src/python/setup.py
1 1 version.m4
-commit 1451c548e5a37c2ff228f2dfccf55d069a408f82
+commit ff0e2ba7fe2247575ab4f545f90a297fe2f56439
Author: Galen Charlton <gmc at equinoxinitiative.org>
-Date: Mon Sep 11 17:20:13 2017 -0400
+Date: Fri Sep 15 10:01:10 2017 -0400
- release notes for 2.5.1
+ release notes for 2.5.2
Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-65 0 doc/RELEASE_NOTES.txt
+23 0 doc/RELEASE_NOTES.txt
-commit a901fa5e4d3ca8cb17362f1e0e5548ee46cf6a7d
+commit e7eee4bd383797c3cf7f99ec4da1b9bdcf4c94e0
Author: Galen Charlton <gmc at equinoxinitiative.org>
-Date: Mon Sep 11 17:01:58 2017 -0400
+Date: Thu Sep 14 17:36:40 2017 -0400
- convert release notes to multi-release format
+ LP#1717350: fix chunking messages sent from Perl services
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-15 11 doc/RELEASE_NOTES.txt
-
-commit 0ae68c0ec5ce4a66e83093d47263e76a0af31746
-Author: Bill Erickson <berickxx at gmail.com>
-Date: Fri Sep 8 17:53:52 2017 -0400
-
- LP#1709710 Count Perl chunk/bundle sizes in bytes
-
- For the purposes of bundling/chunking, count the number of bytes in each
- affected string instead of the number of characters.
+ The chunk size adjustments introduced by the patches for bug 1709710
+ could result in calculating non-integral chunk sizes for Perl services.
+ This in turn led to fractional offsets and lengths being passed to
+ Perl's substr() function; rounding in turn can lead to characters
+ in the response getting silently dropped, which in turn broke
+ parsing the reconstituted response.
- See also https://perldoc.perl.org/bytes.html and 'perldoc -f length'
+ To test
+ -------
+ The problem can be reproduced by invoking
- Signed-off-by: Bill Erickson <berickxx at gmail.com>
- Signed-off-by: Jason Stephenson <jason at sigio.com>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-6 3 src/perl/lib/OpenSRF/AppSession.pm
-
-commit 53565494dbf613faa873139d7a8078d27b9066b4
-Author: Galen Charlton <gmc at equinoxinitiative.org>
-Date: Fri Sep 8 15:34:29 2017 -0400
-
- LP#1709710: write unit tests for osrfXmlEscapingLength()
-
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
- Signed-off-by: Bill Erickson <berickxx at gmail.com>
- Signed-off-by: Jason Stephenson <jason at sigio.com>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-6 2 tests/Makefile.am
-43 0 tests/check_osrf_utils.c
- create mode 100644 tests/check_osrf_utils.c
-
-commit 3f7abf68aeb553f6fd6289935980d01d86f13b66
-Author: Mike Rylander <miker at esilibrary.com>
-Date: Fri Aug 18 11:43:31 2017 -0400
-
- LP#1709710: Make chunk sizing smart about XML quoting
+ open-ils.storage open-ils.storage.actor.org_unit.descendants.atomic 1, 0
- XML inside JSON as a quoted string that's itself inside XML causes quite the
- pile up of nested excaping of certain characters in OpenSRF PARTIAL_RESPONSE
- messages. Here we check for the worst offenders (<, >, &, and ") and account
- for the cost of escaping them in chunked response stanzas.
+ in Evergreen databases with org unit trees large enough that the
+ response gets chunked.
- Signed-off-by: Mike Rylander <mrylander at gmail.com>
Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
- Signed-off-by: Bill Erickson <berickxx at gmail.com>
Signed-off-by: Jason Stephenson <jason at sigio.com>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-6 0 include/opensrf/utils.h
-11 4 src/libopensrf/osrf_app_session.c
-8 3 src/libopensrf/osrf_application.c
-23 0 src/libopensrf/utils.c
-21 3 src/perl/lib/OpenSRF/AppSession.pm
-
-commit 5c94e88fb6b7fafd578fe1e5fb1e844dfbfa0350
-Author: Chris Sharp <csharp at georgialibraries.org>
-Date: Thu May 11 14:47:32 2017 -0400
-
- LP#1690206 - remove check of httpd.conf from OpenSRF Makefile.install
-
- The original src/extras/Makefile.install included a grep of the
- file /etc/apache2/httpd.conf, which is no longer installed by default
- on supported Debian and Ubuntu releases. As this check results in
- an error message, it makes sense to remove the check altogether.
-
- Signed-off-by: Chris Sharp <csharp at georgialibraries.org>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-0 6 src/extras/Makefile.install
-
-commit a9cd1241be01b42aaccc1a0c4a875eba8a9d37ca
-Author: Bill Erickson <berickxx at gmail.com>
-Date: Fri Jun 9 13:01:46 2017 -0400
-
- LP#1697029 Log and exit on write to dead child
-
- Confirm that a child process is alive just before attempting to write to
- its pipe. If the child process is dead, log the error, then drop the
- message and move on. This allows the parent to continue servicing
- future requests.
-
- Signed-off-by: Bill Erickson <berickxx at gmail.com>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-13 0 src/perl/lib/OpenSRF/Server.pm
-
-commit dc3bfa4771e5e5b139d31c73b42562917f100688
-Author: Galen Charlton <gmc at equinoxinitiative.org>
-Date: Fri Aug 18 11:11:29 2017 -0400
-
- LP#1711194: avoid division by zero errors
-
- Under some circumstances, osrf_control --diagnostic may not
- be able to deduce the correct max_children setting for a service,
- e.g., if it's run without --localhost on a system that doesn't
- have a opensrf.xml config section specifying active apps for a
- specific hostname. When that happens, just display the count
- of running drones rather than displaying error messages about
- undefined $dmax values and divisions by zero.
-
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
- Signed-off-by: Bill Erickson <berickxx at gmail.com>
-
-6 2 bin/opensrf-perl.pl.in
-
-commit 2c7b9787c63c8477fc7f1e7b46f1262a62abf6f0
-Author: Bill Erickson <berickxx at gmail.com>
-Date: Wed Aug 16 14:10:13 2017 -0400
-
- LP#1711194 osrf_config --diagnostic reports max-children
-
- --diagnostic output shows the maximum number of allowed drones per
- service along with the active drone count. Additionally, a usage
- percentage value is displayed.
-
- E.g.
-
- $ /openils/bin/osrf_control -l --diagnostic
-
- * open-ils.acq [1581] uptime=00:35 cputime=00:00:00 #drones=1/15 6%
- * open-ils.actor [1629] uptime=00:35 cputime=00:00:00 #drones=2/15 13%
-
- Signed-off-by: Bill Erickson <berickxx at gmail.com>
- Signed-off-by: Chris Sharp <csharp at georgialibraries.org>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-9 1 bin/opensrf-perl.pl.in
-
-commit dab68778d6064b3ff5688ea3c622b38f07b4f993
-Author: Graham Billiau <graham at geeksinthegong.net>
-Date: Mon Jul 31 11:00:25 2017 -0400
-
- LP#1704090: ensure make install respects DESTDIR
-
- This patch ensures that 'make install' uses DESTDIR consistently,
- making life easier for packagers.
-
- Signed-off-by: Graham Billiau <graham at geeksinthegong.net>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-3 3 src/Makefile.am
-7 2 src/gateway/Makefile.am
-
-commit f9344c8d7792bfe233881756ebe4f41896f93916
-Author: Jason Stephenson <jason at sigio.com>
-Date: Wed Jul 12 15:24:48 2017 -0400
-
- LP 1703958: Update Websockets Intructions for Debian Jessie
-
- Modify the Websockets installation instructions so that users will
- have a working installation on Debian Jessie. We change the "Debian"
- instructions to say "Debian Wheezy" and add "Debian Jessie" to the
- list with "Ubuntu Trusty / Xenial" where necessary.
-
- Signed-off-by: Jason Stephenson <jason at sigio.com>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-
-4 4 README
-
-commit 22b5bf2b7606787dedac82c4eaae59b9bf2c7746
-Author: Graham Billiau <graham at geeksinthegong.net>
-Date: Thu Jul 13 11:29:43 2017 -0400
-
- LP#1704116: fix intermittant failure of parallel building
-
- Running make to do a parallel build (e.g., 'make -j 4' or
- the like) could fail because of an undeclared dependency; this
- patch fixes the issue.
-
- The issue can be reproduced by repeating "make clean; make -j 4"
- until the build fails.
-
- Signed-off-by: Graham Billiau <graham at geeksinthegong.net>
- Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
-1 0 src/libopensrf/Makefile.am
+2 1 src/perl/lib/OpenSRF/AppSession.pm
commit e82b9edd077058b252e9e64bccf4fffb0a4fe29e
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date: Fri Sep 15 10:01:33 2017 -0400
update version stamps for 2.5.2
Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
diff --git a/README b/README
index 5ab2af6..d10799b 100644
--- a/README
+++ b/README
@@ -29,7 +29,7 @@ Issue the following commands as the *user* Linux account.
+
[source, bash]
------------------------------------------------------------------------------
-wget https://evergreen-ils.org/downloads/opensrf-2.5.1.tar.gz
+wget https://evergreen-ils.org/downloads/opensrf-2.5.2.tar.gz
------------------------------------------------------------------------------
+
[NOTE]
@@ -40,8 +40,8 @@ http://git.evergreen-ils.org/?p=OpenSRF.git
+
[source, bash]
------------------------------------------------------------------------------
-tar -xvf opensrf-2.5.1.tar.gz
-cd opensrf-2.5.1/
+tar -xvf opensrf-2.5.2.tar.gz
+cd opensrf-2.5.2/
------------------------------------------------------------------------------
Installing prerequisites
@@ -468,14 +468,14 @@ a2dismod websocket
.(Debian Wheezy)
[source, bash]
---------------------------------------------------------------------------
-cd /path/to/opensrf-2.5.1
+cd /path/to/opensrf-2.5.2
cp examples/apache2/websockets/apache2.conf /etc/apache2-websockets/
---------------------------------------------------------------------------
+
.(Debian Jessie / Ubuntu Trusty / Xenial)
[source, bash]
---------------------------------------------------------------------------
-cd /path/to/opensrf-2.5.1
+cd /path/to/opensrf-2.5.2
cp examples/apache_24/websockets/apache2.conf /etc/apache2-websockets/
---------------------------------------------------------------------------
+
@@ -548,7 +548,7 @@ apt-get install nginx
+
[source, bash]
---------------------------------------------------------------------------
-cd /path/to/opensrf-2.5.1
+cd /path/to/opensrf-2.5.2
cp examples/nginx/osrf-ws-http-proxy /etc/nginx/sites-available/
ln -s /etc/nginx/sites-available/osrf-ws-http-proxy /etc/nginx/sites-enabled/osrf-ws-http-proxy
rm /etc/nginx/sites-enabled/default
@@ -604,7 +604,7 @@ apt-get install haproxy
+
[source, bash]
---------------------------------------------------------------------------
-cd /path/to/opensrf-2.5.1
+cd /path/to/opensrf-2.5.2
cat examples/haproxy/osrf-ws-http-proxy >> /etc/haproxy/haproxy.cfg
---------------------------------------------------------------------------
+
diff --git a/src/perl/lib/OpenSRF.pm b/src/perl/lib/OpenSRF.pm
index 514e9bd..6ccbb8b 100644
--- a/src/perl/lib/OpenSRF.pm
+++ b/src/perl/lib/OpenSRF.pm
@@ -12,11 +12,11 @@ OpenSRF - Top level class for OpenSRF perl modules.
=head1 VERSION
-Version 2.5.1
+Version 2.5.2
=cut
-our $VERSION = "2.51";
+our $VERSION = "2.52";
=head1 METHODS
diff --git a/src/python/setup.py b/src/python/setup.py
index 97d3315..3367731 100644
--- a/src/python/setup.py
+++ b/src/python/setup.py
@@ -3,7 +3,7 @@
from setuptools import setup
setup(name='OpenSRF',
- version='2.5.1',
+ version='2.5.2',
install_requires=[
'dnspython', # required by pyxmpp
'python-memcached',
diff --git a/version.m4 b/version.m4
index bb0eb60..d92145f 100644
--- a/version.m4
+++ b/version.m4
@@ -1 +1 @@
-m4_define([VERSION_NUMBER],[2.5.1])
+m4_define([VERSION_NUMBER],[2.5.2])
commit ff0e2ba7fe2247575ab4f545f90a297fe2f56439
Author: Galen Charlton <gmc at equinoxinitiative.org>
Date: Fri Sep 15 10:01:10 2017 -0400
release notes for 2.5.2
Signed-off-by: Galen Charlton <gmc at equinoxinitiative.org>
diff --git a/doc/RELEASE_NOTES.txt b/doc/RELEASE_NOTES.txt
index 07ab77b..965da01 100644
--- a/doc/RELEASE_NOTES.txt
+++ b/doc/RELEASE_NOTES.txt
@@ -8,6 +8,29 @@ The following Linux distributions are well-tested:
* Debian 7 (Wheezy) and 8 (Jessie)
* Ubuntu 14.04 (Trusty Tahr) and 16.04 LTS (Xenial Xerus)
+OpenSRF 2.5.2
+-------------
+OpenSRF 2.5.2 was released on 15 September 2017. It fixes a significant
+bug introduced in OpenSRF 2.5.1. All users of OpenSRF 2.5.1 are advised
+to upgrade as soon as possible.
+
+In particular, it fixes LP#1717350; an error in how large messages were
+split during the chunking process resulted in characters sometimes getting
+dropped at the divison points.
+
+Acknowledgements
+~~~~~~~~~~~~~~~~
+
+We would like to thank the following people who contributed to OpenSRF 2.5.2
+and to the reporting and analysis of the bug:
+
+ * Bill Erickson
+ * Dan Wells
+ * Galen Charlton
+ * Jason Stephenson
+ * Jeff Davis
+ * Mike Rylander
+
OpenSRF 2.5.1
-------------
-----------------------------------------------------------------------
Summary of changes:
ChangeLog | 207 +++++-----------------------------------------
README | 14 ++--
doc/RELEASE_NOTES.txt | 23 +++++
src/perl/lib/OpenSRF.pm | 4 +-
src/python/setup.py | 2 +-
version.m4 | 2 +-
6 files changed, 57 insertions(+), 195 deletions(-)
hooks/post-receive
--
OpenSRF
More information about the opensrf-commits
mailing list