April 2025 - Evergreen-commits

[GIT] Evergreen ILS branch rel_3_15 updated. a74eee956bea793f9f7f769a48de3303b1fd109d
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_15 has been updated via a74eee956bea793f9f7f769a48de3303b1fd109d (commit) via 8028098a2b737824e42e13a846d0780e22494f45 (commit) from 9e153c29bda5658390ea6a6f5aacb680f91021dc (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit a74eee956bea793f9f7f769a48de3303b1fd109d Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Tue Mar 11 14:24:41 2025 +0000 LP2085844 Org-select keyboard, focus, & scrolling Adds the scroll-into-view capability to the org-select component, as well as other keyboard- and focus-related features that have been implemented in combobox but were never copied into org-select. Release-note: Replicate combobox keyboard, focus features in org-select Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Llewellyn Marshall <llewellyn.marshall(a)dncr.nc.gov> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts b/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts index 1f033be1ad..fd4c23b747 100644 --- a/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts +++ b/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts @@ -66,6 +66,7 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { valueFromSetting: number = null; sortedOrgs: IdlObject[] = []; orgSelectGroup: FormGroup; + controller: HTMLInputElement; // Disable the entire input @Input() disabled: boolean; @@ -78,6 +79,10 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { // ARIA label for selector. Required if there is no <label> in the markup. @Input() ariaLabel?: string; + // Optionally provide an aria-labelledby for the input. This should be one or more + // space-delimited ids of elements that describe this combobox. + @Input() ariaLabelledby: string; + // ARIA describedby, for attaching error messages @Input() ariaDescribedby?: string = null; @@ -271,7 +276,9 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { } ngAfterViewInit(): void { - this.elm.nativeElement.querySelector('input').addEventListener('keydown', this.onKeydown.bind(this)); + document.querySelectorAll('ngb-typeahead-window button[disabled]').forEach(b => b.setAttribute('tabindex', '-1')); + this.controller = this.instance['_elementRef'].nativeElement as HTMLInputElement; + this.controller.addEventListener('keydown', this.onKeydown.bind(this)); } getDisplayLabel(org: IdlObject): string { @@ -381,6 +388,9 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { // console.debug('Key: ', $event); if (this.instance.isPopupOpen()) { + if ($event.key === 'ArrowUp' || $event.key === 'ArrowDown') { + this.scrollEntries(); + } return; } @@ -409,6 +419,27 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { setTimeout(() => this.click$.next('')); } + closeMe($event) { + this.instance.dismissPopup(); + } + + scrollEntries() { + // adapted from https://github.com/ng-bootstrap/ng-bootstrap/issues/4789 + if (!this.controller) {return;} + + const listbox = document.getElementById(this.controller.getAttribute('aria-owns')); + // console.debug("Listbox: ", listbox); + + const activeItem = document.getElementById(this.controller.getAttribute('aria-activedescendant')); + if (activeItem) { + if (activeItem.offsetTop < listbox.scrollTop) { + listbox.scrollTo({ top: activeItem.offsetTop }); + } else if (activeItem.offsetTop + activeItem.offsetHeight > listbox.scrollTop + listbox.clientHeight) { + listbox.scrollTo({ top: activeItem.offsetTop + activeItem.offsetHeight - listbox.clientHeight }); + } + } + } + // NgbTypeahead doesn't offer a way to style the dropdown // button directly, so we have to reach up and style it ourselves. applyDisableStyle() { commit 8028098a2b737824e42e13a846d0780e22494f45 Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Mon Mar 10 21:27:25 2025 +0000 LP2085844 Scroll focused combobox option into view When using the arrow up/down keys to scroll through the list of combobox suggestions, the listbox now scrolls to keep the focused option in view. Based on commenters' solutions from: https://github.com/ng-bootstrap/ng-bootstrap/issues/4789 Release-note: Scroll focused combobox option into view on arrow up/down Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Llewellyn Marshall <llewellyn.marshall(a)dncr.nc.gov> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts index 201a7ef6cf..5805ccfe5a 100644 --- a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts +++ b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts @@ -57,6 +57,7 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { selected: ComboboxEntry; click$: Subject<string>; entrylist: ComboboxEntry[]; + controller: HTMLInputElement; @ViewChild('instance', {static: false}) instance: NgbTypeahead; @ViewChild('defaultDisplayTemplate', {static: true}) defaultDisplayTemplate: TemplateRef<any>; @@ -401,9 +402,10 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { if (!this.selectedId && !this.selected){ this.selected = this.entrylist.find(e => e.id == null); } - + document.querySelectorAll('ngb-typeahead-window button[disabled]').forEach(b => b.setAttribute('tabindex', '-1')); - this.elm.nativeElement.querySelector('input').addEventListener('keydown', this.onKeydown.bind(this)); + this.controller = this.instance['_elementRef'].nativeElement as HTMLInputElement; + this.controller.addEventListener('keydown', this.onKeydown.bind(this)); } ngOnChanges(changes: SimpleChanges) { @@ -474,6 +476,9 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { //console.debug('Key: ', $event); if (this.instance.isPopupOpen()) { + if ($event.key === 'ArrowUp' || $event.key === 'ArrowDown') { + this.scrollEntries(); + } return; } @@ -495,6 +500,24 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { this.comboboxEnter.emit(this.selected.id); } + scrollEntries() { + // adapted from https://github.com/ng-bootstrap/ng-bootstrap/issues/4789 + if (!this.controller) + return; + + const listbox = document.getElementById(this.controller.getAttribute('aria-owns')); + // console.debug("Listbox: ", listbox); + + const activeItem = document.getElementById(this.controller.getAttribute('aria-activedescendant')); + if (activeItem) { + if (activeItem.offsetTop < listbox.scrollTop) { + listbox.scrollTo({ top: activeItem.offsetTop }); + } else if (activeItem.offsetTop + activeItem.offsetHeight > listbox.scrollTop + listbox.clientHeight) { + listbox.scrollTo({ top: activeItem.offsetTop + activeItem.offsetHeight - listbox.clientHeight }); + } + } + } + openMe($event) { // Give the input a chance to focus then fire the click // handler to force open the typeahead ----------------------------------------------------------------------- Summary of changes: .../src/app/share/combobox/combobox.component.ts | 27 ++++++++++++++++-- .../app/share/org-select/org-select.component.ts | 33 +++++++++++++++++++++- 2 files changed, 57 insertions(+), 3 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch main updated. 62002e41e6c13144cfedf2e233f6025abba2303d
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via 62002e41e6c13144cfedf2e233f6025abba2303d (commit) via 4592b8d034178759a81fcf26f5d2fabd513a4bfc (commit) from 0d1fec8082165b2210551386db0dc1d5007bb92f (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 62002e41e6c13144cfedf2e233f6025abba2303d Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Tue Mar 11 14:24:41 2025 +0000 LP2085844 Org-select keyboard, focus, & scrolling Adds the scroll-into-view capability to the org-select component, as well as other keyboard- and focus-related features that have been implemented in combobox but were never copied into org-select. Release-note: Replicate combobox keyboard, focus features in org-select Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Llewellyn Marshall <llewellyn.marshall(a)dncr.nc.gov> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts b/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts index 1f033be1ad..fd4c23b747 100644 --- a/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts +++ b/Open-ILS/src/eg2/src/app/share/org-select/org-select.component.ts @@ -66,6 +66,7 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { valueFromSetting: number = null; sortedOrgs: IdlObject[] = []; orgSelectGroup: FormGroup; + controller: HTMLInputElement; // Disable the entire input @Input() disabled: boolean; @@ -78,6 +79,10 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { // ARIA label for selector. Required if there is no <label> in the markup. @Input() ariaLabel?: string; + // Optionally provide an aria-labelledby for the input. This should be one or more + // space-delimited ids of elements that describe this combobox. + @Input() ariaLabelledby: string; + // ARIA describedby, for attaching error messages @Input() ariaDescribedby?: string = null; @@ -271,7 +276,9 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { } ngAfterViewInit(): void { - this.elm.nativeElement.querySelector('input').addEventListener('keydown', this.onKeydown.bind(this)); + document.querySelectorAll('ngb-typeahead-window button[disabled]').forEach(b => b.setAttribute('tabindex', '-1')); + this.controller = this.instance['_elementRef'].nativeElement as HTMLInputElement; + this.controller.addEventListener('keydown', this.onKeydown.bind(this)); } getDisplayLabel(org: IdlObject): string { @@ -381,6 +388,9 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { // console.debug('Key: ', $event); if (this.instance.isPopupOpen()) { + if ($event.key === 'ArrowUp' || $event.key === 'ArrowDown') { + this.scrollEntries(); + } return; } @@ -409,6 +419,27 @@ export class OrgSelectComponent implements OnInit, AfterViewInit { setTimeout(() => this.click$.next('')); } + closeMe($event) { + this.instance.dismissPopup(); + } + + scrollEntries() { + // adapted from https://github.com/ng-bootstrap/ng-bootstrap/issues/4789 + if (!this.controller) {return;} + + const listbox = document.getElementById(this.controller.getAttribute('aria-owns')); + // console.debug("Listbox: ", listbox); + + const activeItem = document.getElementById(this.controller.getAttribute('aria-activedescendant')); + if (activeItem) { + if (activeItem.offsetTop < listbox.scrollTop) { + listbox.scrollTo({ top: activeItem.offsetTop }); + } else if (activeItem.offsetTop + activeItem.offsetHeight > listbox.scrollTop + listbox.clientHeight) { + listbox.scrollTo({ top: activeItem.offsetTop + activeItem.offsetHeight - listbox.clientHeight }); + } + } + } + // NgbTypeahead doesn't offer a way to style the dropdown // button directly, so we have to reach up and style it ourselves. applyDisableStyle() { commit 4592b8d034178759a81fcf26f5d2fabd513a4bfc Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Mon Mar 10 21:27:25 2025 +0000 LP2085844 Scroll focused combobox option into view When using the arrow up/down keys to scroll through the list of combobox suggestions, the listbox now scrolls to keep the focused option in view. Based on commenters' solutions from: https://github.com/ng-bootstrap/ng-bootstrap/issues/4789 Release-note: Scroll focused combobox option into view on arrow up/down Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Llewellyn Marshall <llewellyn.marshall(a)dncr.nc.gov> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts index 201a7ef6cf..5805ccfe5a 100644 --- a/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts +++ b/Open-ILS/src/eg2/src/app/share/combobox/combobox.component.ts @@ -57,6 +57,7 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { selected: ComboboxEntry; click$: Subject<string>; entrylist: ComboboxEntry[]; + controller: HTMLInputElement; @ViewChild('instance', {static: false}) instance: NgbTypeahead; @ViewChild('defaultDisplayTemplate', {static: true}) defaultDisplayTemplate: TemplateRef<any>; @@ -401,9 +402,10 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { if (!this.selectedId && !this.selected){ this.selected = this.entrylist.find(e => e.id == null); } - + document.querySelectorAll('ngb-typeahead-window button[disabled]').forEach(b => b.setAttribute('tabindex', '-1')); - this.elm.nativeElement.querySelector('input').addEventListener('keydown', this.onKeydown.bind(this)); + this.controller = this.instance['_elementRef'].nativeElement as HTMLInputElement; + this.controller.addEventListener('keydown', this.onKeydown.bind(this)); } ngOnChanges(changes: SimpleChanges) { @@ -474,6 +476,9 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { //console.debug('Key: ', $event); if (this.instance.isPopupOpen()) { + if ($event.key === 'ArrowUp' || $event.key === 'ArrowDown') { + this.scrollEntries(); + } return; } @@ -495,6 +500,24 @@ implements ControlValueAccessor, OnInit, AfterViewInit, OnChanges { this.comboboxEnter.emit(this.selected.id); } + scrollEntries() { + // adapted from https://github.com/ng-bootstrap/ng-bootstrap/issues/4789 + if (!this.controller) + return; + + const listbox = document.getElementById(this.controller.getAttribute('aria-owns')); + // console.debug("Listbox: ", listbox); + + const activeItem = document.getElementById(this.controller.getAttribute('aria-activedescendant')); + if (activeItem) { + if (activeItem.offsetTop < listbox.scrollTop) { + listbox.scrollTo({ top: activeItem.offsetTop }); + } else if (activeItem.offsetTop + activeItem.offsetHeight > listbox.scrollTop + listbox.clientHeight) { + listbox.scrollTo({ top: activeItem.offsetTop + activeItem.offsetHeight - listbox.clientHeight }); + } + } + } + openMe($event) { // Give the input a chance to focus then fire the click // handler to force open the typeahead ----------------------------------------------------------------------- Summary of changes: .../src/app/share/combobox/combobox.component.ts | 27 ++++++++++++++++-- .../app/share/org-select/org-select.component.ts | 33 +++++++++++++++++++++- 2 files changed, 57 insertions(+), 3 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch rel_3_13 updated. cd6f36548152cab1203bbb9dcd64aab9bded6fc2
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_13 has been updated via cd6f36548152cab1203bbb9dcd64aab9bded6fc2 (commit) from 7d2ab9256f91c260b7d9bd83a7c33cb934424533 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit cd6f36548152cab1203bbb9dcd64aab9bded6fc2 Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Sun Mar 30 04:26:02 2025 +0000 LP2040183 Form labels for patron survey answers Changes the patron survey answers (in the AngularJS staff patron registration form) from button dropdowns to form select elements with proper labels. Allows the survey answers to be set using the keyboard. Release-note: Form labels and keyboard support for patron survey answers Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 index cfad267557..b7bfa1fadc 100644 --- a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 +++ b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 @@ -1226,24 +1226,14 @@ within the "form" by name for validation. <div class="col-md-6 reg-field-input"> <div class="row" ng-repeat="question in survey.questions()" style="margin-bottom: 10px;"> - <div class="col-md-6">{{question.question()}}</div> + <label class="col-form-label col-md-6" for="survey_responses-{{question.id()}}"> + {{question.question()}} + </label> <div class="col-md-6"> - <div class="btn-group" uib-dropdown> - <button type="button" class="btn btn-default" uib-dropdown-toggle> - <span style="padding-right: 5px;"> - {{survey_responses[question.id()].answer()}} - </span> - <span class="caret"></span> - </button> - <ul uib-dropdown-menu> - <li ng-repeat="answer in question.answers()"> - <a href - ng-click="field_modified();survey_responses[question.id()] = answer"> - {{answer.answer()}} - </a> - </li> - </ul> - </div> + <select id="survey_responses-{{question.id()}}" class="form-control form-select" + ng-model="survey_responses[question.id()]" + ng-options="answer.answer() for answer in question.answers() track by answer.id()" + ng-change="field_modified();survey_responses[question.id()] = answer"></select> </div> </div> </div> ----------------------------------------------------------------------- Summary of changes: .../src/templates/staff/circ/patron/t_edit.tt2 | 24 +++++++--------------- 1 file changed, 7 insertions(+), 17 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch rel_3_14 updated. 4130ba116b9f0f5c85890d59c994e8d29149dbe6
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_14 has been updated via 4130ba116b9f0f5c85890d59c994e8d29149dbe6 (commit) from 680349c08459576477c8d328cb0d94ad0bd30642 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 4130ba116b9f0f5c85890d59c994e8d29149dbe6 Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Sun Mar 30 04:26:02 2025 +0000 LP2040183 Form labels for patron survey answers Changes the patron survey answers (in the AngularJS staff patron registration form) from button dropdowns to form select elements with proper labels. Allows the survey answers to be set using the keyboard. Release-note: Form labels and keyboard support for patron survey answers Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 index cfad267557..b7bfa1fadc 100644 --- a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 +++ b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 @@ -1226,24 +1226,14 @@ within the "form" by name for validation. <div class="col-md-6 reg-field-input"> <div class="row" ng-repeat="question in survey.questions()" style="margin-bottom: 10px;"> - <div class="col-md-6">{{question.question()}}</div> + <label class="col-form-label col-md-6" for="survey_responses-{{question.id()}}"> + {{question.question()}} + </label> <div class="col-md-6"> - <div class="btn-group" uib-dropdown> - <button type="button" class="btn btn-default" uib-dropdown-toggle> - <span style="padding-right: 5px;"> - {{survey_responses[question.id()].answer()}} - </span> - <span class="caret"></span> - </button> - <ul uib-dropdown-menu> - <li ng-repeat="answer in question.answers()"> - <a href - ng-click="field_modified();survey_responses[question.id()] = answer"> - {{answer.answer()}} - </a> - </li> - </ul> - </div> + <select id="survey_responses-{{question.id()}}" class="form-control form-select" + ng-model="survey_responses[question.id()]" + ng-options="answer.answer() for answer in question.answers() track by answer.id()" + ng-change="field_modified();survey_responses[question.id()] = answer"></select> </div> </div> </div> ----------------------------------------------------------------------- Summary of changes: .../src/templates/staff/circ/patron/t_edit.tt2 | 24 +++++++--------------- 1 file changed, 7 insertions(+), 17 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch rel_3_15 updated. 9e153c29bda5658390ea6a6f5aacb680f91021dc
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_15 has been updated via 9e153c29bda5658390ea6a6f5aacb680f91021dc (commit) from ae8e56689d6cf01a4fe84d1aad0d87e3a9aa6eb7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 9e153c29bda5658390ea6a6f5aacb680f91021dc Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Sun Mar 30 04:26:02 2025 +0000 LP2040183 Form labels for patron survey answers Changes the patron survey answers (in the AngularJS staff patron registration form) from button dropdowns to form select elements with proper labels. Allows the survey answers to be set using the keyboard. Release-note: Form labels and keyboard support for patron survey answers Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 index cfad267557..b7bfa1fadc 100644 --- a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 +++ b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 @@ -1226,24 +1226,14 @@ within the "form" by name for validation. <div class="col-md-6 reg-field-input"> <div class="row" ng-repeat="question in survey.questions()" style="margin-bottom: 10px;"> - <div class="col-md-6">{{question.question()}}</div> + <label class="col-form-label col-md-6" for="survey_responses-{{question.id()}}"> + {{question.question()}} + </label> <div class="col-md-6"> - <div class="btn-group" uib-dropdown> - <button type="button" class="btn btn-default" uib-dropdown-toggle> - <span style="padding-right: 5px;"> - {{survey_responses[question.id()].answer()}} - </span> - <span class="caret"></span> - </button> - <ul uib-dropdown-menu> - <li ng-repeat="answer in question.answers()"> - <a href - ng-click="field_modified();survey_responses[question.id()] = answer"> - {{answer.answer()}} - </a> - </li> - </ul> - </div> + <select id="survey_responses-{{question.id()}}" class="form-control form-select" + ng-model="survey_responses[question.id()]" + ng-options="answer.answer() for answer in question.answers() track by answer.id()" + ng-change="field_modified();survey_responses[question.id()] = answer"></select> </div> </div> </div> ----------------------------------------------------------------------- Summary of changes: .../src/templates/staff/circ/patron/t_edit.tt2 | 24 +++++++--------------- 1 file changed, 7 insertions(+), 17 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch main updated. 0d1fec8082165b2210551386db0dc1d5007bb92f
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via 0d1fec8082165b2210551386db0dc1d5007bb92f (commit) from d945ab98027598b638b842df2ef9d01410c0a821 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 0d1fec8082165b2210551386db0dc1d5007bb92f Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Sun Mar 30 04:26:02 2025 +0000 LP2040183 Form labels for patron survey answers Changes the patron survey answers (in the AngularJS staff patron registration form) from button dropdowns to form select elements with proper labels. Allows the survey answers to be set using the keyboard. Release-note: Form labels and keyboard support for patron survey answers Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 index cfad267557..b7bfa1fadc 100644 --- a/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 +++ b/Open-ILS/src/templates/staff/circ/patron/t_edit.tt2 @@ -1226,24 +1226,14 @@ within the "form" by name for validation. <div class="col-md-6 reg-field-input"> <div class="row" ng-repeat="question in survey.questions()" style="margin-bottom: 10px;"> - <div class="col-md-6">{{question.question()}}</div> + <label class="col-form-label col-md-6" for="survey_responses-{{question.id()}}"> + {{question.question()}} + </label> <div class="col-md-6"> - <div class="btn-group" uib-dropdown> - <button type="button" class="btn btn-default" uib-dropdown-toggle> - <span style="padding-right: 5px;"> - {{survey_responses[question.id()].answer()}} - </span> - <span class="caret"></span> - </button> - <ul uib-dropdown-menu> - <li ng-repeat="answer in question.answers()"> - <a href - ng-click="field_modified();survey_responses[question.id()] = answer"> - {{answer.answer()}} - </a> - </li> - </ul> - </div> + <select id="survey_responses-{{question.id()}}" class="form-control form-select" + ng-model="survey_responses[question.id()]" + ng-options="answer.answer() for answer in question.answers() track by answer.id()" + ng-change="field_modified();survey_responses[question.id()] = answer"></select> </div> </div> </div> ----------------------------------------------------------------------- Summary of changes: .../src/templates/staff/circ/patron/t_edit.tt2 | 24 +++++++--------------- 1 file changed, 7 insertions(+), 17 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch rel_3_15 updated. ae8e56689d6cf01a4fe84d1aad0d87e3a9aa6eb7
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_15 has been updated via ae8e56689d6cf01a4fe84d1aad0d87e3a9aa6eb7 (commit) from 88ef80372eda082699121fdc0753dcd5cdffa944 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit ae8e56689d6cf01a4fe84d1aad0d87e3a9aa6eb7 Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Wed Apr 2 22:56:42 2025 +0000 LP2106057 Do not show open_in_new icon on images The CSS that automatically appends the open_in_new icon to links that open in new tabs should disregard links that contain <img> tags, to avoid infelicities like the icon appearing on the next line below a record's cover image. Also adds a small inline margin to the icon to separate it from link text a bit. Removes component-specific styles that are now redundant. Release-note: Do not show open_in_new icon on links containing images Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css b/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css index 8a0370d680..7d2aa10fe6 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css +++ b/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css @@ -9,13 +9,6 @@ transition: opacity 0.5s ease-in-out; } -.tagmap-actions .edit-link:after { - display: inline; - content: "\e89e"; /* opens in new window icon */ - font-family: "Material Icons"; - line-height: inherit; -} - ::ng-deep .eg-grid-row:not(:has(:hover, :focus, :focus-visible)) .tagmap-actions { opacity: 0 !important; } diff --git a/Open-ILS/src/eg2/src/styles.css b/Open-ILS/src/eg2/src/styles.css index 29fd521ffe..7f04caf7e1 100644 --- a/Open-ILS/src/eg2/src/styles.css +++ b/Open-ILS/src/eg2/src/styles.css @@ -123,11 +123,12 @@ a:not(.alert-link):is(:hover, :focus, :focus-visible), filter: brightness(1.1); } -a[target="_blank"]:after { +a[target="_blank"]:not(:has(img)):after { display: inline; - content: "\e89e"; + content: "open_in_new"; font-family: "Material Icons"; line-height: inherit; + margin-inline-start: 0.25rem; } /** BS has flex utility classes, but none for specifying flex widths. ----------------------------------------------------------------------- Summary of changes: .../eg2/src/app/staff/share/holdings/tag-map-list.component.css | 7 ------- Open-ILS/src/eg2/src/styles.css | 5 +++-- 2 files changed, 3 insertions(+), 9 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch main updated. d945ab98027598b638b842df2ef9d01410c0a821
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via d945ab98027598b638b842df2ef9d01410c0a821 (commit) from 730513fbf0f8516a3a4dfaf704ee0e8d0a5bcc19 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit d945ab98027598b638b842df2ef9d01410c0a821 Author: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Date: Wed Apr 2 22:56:42 2025 +0000 LP2106057 Do not show open_in_new icon on images The CSS that automatically appends the open_in_new icon to links that open in new tabs should disregard links that contain <img> tags, to avoid infelicities like the icon appearing on the next line below a record's cover image. Also adds a small inline margin to the icon to separate it from link text a bit. Removes component-specific styles that are now redundant. Release-note: Do not show open_in_new icon on links containing images Signed-off-by: Stephanie Leary <stephanie.leary(a)equinoxoli.org> Signed-off-by: Terran McCanna <tmccanna(a)georgialibraries.org> diff --git a/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css b/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css index 8a0370d680..7d2aa10fe6 100644 --- a/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css +++ b/Open-ILS/src/eg2/src/app/staff/share/holdings/tag-map-list.component.css @@ -9,13 +9,6 @@ transition: opacity 0.5s ease-in-out; } -.tagmap-actions .edit-link:after { - display: inline; - content: "\e89e"; /* opens in new window icon */ - font-family: "Material Icons"; - line-height: inherit; -} - ::ng-deep .eg-grid-row:not(:has(:hover, :focus, :focus-visible)) .tagmap-actions { opacity: 0 !important; } diff --git a/Open-ILS/src/eg2/src/styles.css b/Open-ILS/src/eg2/src/styles.css index 29fd521ffe..7f04caf7e1 100644 --- a/Open-ILS/src/eg2/src/styles.css +++ b/Open-ILS/src/eg2/src/styles.css @@ -123,11 +123,12 @@ a:not(.alert-link):is(:hover, :focus, :focus-visible), filter: brightness(1.1); } -a[target="_blank"]:after { +a[target="_blank"]:not(:has(img)):after { display: inline; - content: "\e89e"; + content: "open_in_new"; font-family: "Material Icons"; line-height: inherit; + margin-inline-start: 0.25rem; } /** BS has flex utility classes, but none for specifying flex widths. ----------------------------------------------------------------------- Summary of changes: .../eg2/src/app/staff/share/holdings/tag-map-list.component.css | 7 ------- Open-ILS/src/eg2/src/styles.css | 5 +++-- 2 files changed, 3 insertions(+), 9 deletions(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch rel_3_15 updated. 88ef80372eda082699121fdc0753dcd5cdffa944
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, rel_3_15 has been updated via 88ef80372eda082699121fdc0753dcd5cdffa944 (commit) from c7c51f2e0e255ea3f46537341e53f95934e0c05d (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 88ef80372eda082699121fdc0753dcd5cdffa944 Author: Jane Sandberg <js7389(a)princeton.edu> Date: Thu Apr 3 11:40:22 2025 -0700 Add 3.15 to antora Signed-off-by: Jane Sandberg <js7389(a)princeton.edu> diff --git a/docs/site.yml b/docs/site.yml index d20069c0b7..3f0956713d 100644 --- a/docs/site.yml +++ b/docs/site.yml @@ -6,7 +6,7 @@ content: sources: - url: ../ # - url: git://git.evergreen-ils.org/Evergreen.git - branches: [main, rel_3_14, rel_3_13, rel_3_12, rel_3_11, rel_3_10, rel_3_9, rel_3_8, rel_3_7, rel_3_6] + branches: [main, rel_3_15, rel_3_14, rel_3_13, rel_3_12, rel_3_11, rel_3_10, rel_3_9, rel_3_8, rel_3_7, rel_3_6] start_path: docs ui: bundle: ----------------------------------------------------------------------- Summary of changes: docs/site.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Evergreen ILS

1 0

[GIT] Evergreen ILS branch main updated. 730513fbf0f8516a3a4dfaf704ee0e8d0a5bcc19
by Git User 03 Apr '25

03 Apr '25

This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project "Evergreen ILS". The branch, main has been updated via 730513fbf0f8516a3a4dfaf704ee0e8d0a5bcc19 (commit) from 9d2e245b6814bdf5aa7082810f4b72b151bcb4f7 (commit) Those revisions listed above that are new to this repository have not appeared on any other notification email; so we list those revisions in full, below. - Log ----------------------------------------------------------------- commit 730513fbf0f8516a3a4dfaf704ee0e8d0a5bcc19 Author: Jane Sandberg <js7389(a)princeton.edu> Date: Thu Apr 3 11:40:22 2025 -0700 Add 3.15 to antora Signed-off-by: Jane Sandberg <js7389(a)princeton.edu> diff --git a/docs/site.yml b/docs/site.yml index d20069c0b7..3f0956713d 100644 --- a/docs/site.yml +++ b/docs/site.yml @@ -6,7 +6,7 @@ content: sources: - url: ../ # - url: git://git.evergreen-ils.org/Evergreen.git - branches: [main, rel_3_14, rel_3_13, rel_3_12, rel_3_11, rel_3_10, rel_3_9, rel_3_8, rel_3_7, rel_3_6] + branches: [main, rel_3_15, rel_3_14, rel_3_13, rel_3_12, rel_3_11, rel_3_10, rel_3_9, rel_3_8, rel_3_7, rel_3_6] start_path: docs ui: bundle: ----------------------------------------------------------------------- Summary of changes: docs/site.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) hooks/post-receive -- Evergreen ILS

1 0